Skip to content

Commit

Permalink
t0210,t0211: unset SANITIZE_LEAK
Browse files Browse the repository at this point in the history
Turn off TEST_PASSES_SANITIZE_LEAK in t0210 and t0211 tests.

The tests added in a previous commit to confirm that we redact URLs in
the Trace2 output uncovered leaks in `builtin/clone.c` and `remote.c`.

We observed that (1) `the_repository->remote_status` is not released
properly.

And (2) that we are using `url...insteadOf` and that runs into a code
path where an allocated URL is replaced with another URL.

And (3) `remote_states` contains plenty of `struct remote`s whose
refspecs seem to be usually allocated by never released.

More investigation is needed here to identify the exact cause and
proper fixes these leaks / bugs.

Signed-off-by: Jeff Hostetler <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
  • Loading branch information
jeffhostetler authored and dscho committed Nov 21, 2023
1 parent 56f417d commit 0d28692
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion t/t0210-trace2-normal.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

test_description='test trace2 facility (normal target)'

TEST_PASSES_SANITIZE_LEAK=true
TEST_PASSES_SANITIZE_LEAK=false
. ./test-lib.sh

# Turn off any inherited trace2 settings for this test.
Expand Down
2 changes: 1 addition & 1 deletion t/t0211-trace2-perf.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

test_description='test trace2 facility (perf target)'

TEST_PASSES_SANITIZE_LEAK=true
TEST_PASSES_SANITIZE_LEAK=false
. ./test-lib.sh

# Turn off any inherited trace2 settings for this test.
Expand Down

0 comments on commit 0d28692

Please sign in to comment.