SmbShare, UserAccountControl - fix issues with access control paramet…

…ers, DWord registry value types (#424)
dsccommunity · Apr 24, 2024 · e5f1ccc · e5f1ccc
1 parent 1abe0d6
commit e5f1ccc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - AppVeyor build now sets the correct module version to be able to run tests.
 - ScheduledTask
   - Allowed values for ScheduleType updated to accept AtLogon over AtLogOn - Fixes [Issue #420](https://github.com/dsccommunity/ComputerManagementDsc/issues/420)
+- SmbShare
+  - Allow Test-TargetResource to succeed when access entries use different order - Fixes [Issue #247](https://github.com/dsccommunity/ComputerManagementDsc/issues/247), [Issue #423](https://github.com/dsccommunity/ComputerManagementDsc/issues/423)
+- UserAccountControl
+  - Ensure registry keys are created as REG_DWORD rather than REG_SZ - Fixes [Issue #412](https://github.com/dsccommunity/ComputerManagementDsc/issues/412)
 
 ## [9.0.0] - 2023-02-22
 

diff --git a/source/DSCResources/DSC_SmbShare/DSC_SmbShare.psm1 b/source/DSCResources/DSC_SmbShare/DSC_SmbShare.psm1
@@ -531,6 +531,7 @@ function Test-TargetResource
             $resourceRequiresUpdate = Test-DscParameterState `
                 -CurrentValues $currentSmbShareConfiguration `
                 -DesiredValues $PSBoundParameters `
+                -SortArrayValues `
                 -Verbose:$VerbosePreference
         }
         else

diff --git a/source/DSCResources/DSC_UserAccountControl/DSC_UserAccountControl.psm1 b/source/DSCResources/DSC_UserAccountControl/DSC_UserAccountControl.psm1
@@ -225,6 +225,7 @@ function Set-TargetResource
                         Path = $script:registryKey
                         Name = $parameterName
                         Value = $PSBoundParameters.$parameterName
+                        Type = 'DWord'
                         ErrorAction = 'Stop'
                     }
 
@@ -533,6 +534,7 @@ function Set-UserAccountControlToNotificationLevel
     {
         $defaultSetItemPropertyParameters = @{
             Path = $script:registryKey
+            Type = 'DWord'
             ErrorAction = 'Stop'
         }