Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveDirectoryCSDsc:Update LICENSE file to match the Microsoft Open Source Team standard. Resolves issue #61 #63

Merged
merged 2 commits into from
Oct 30, 2018

Conversation

timhaintz
Copy link
Contributor

@timhaintz timhaintz commented Oct 29, 2018

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@timhaintz timhaintz changed the title ActiveDirectoryCSDsc:Update LICENSE file to match the Microsoft Open Source Team standard. Issue #61 ActiveDirectoryCSDsc:Update LICENSE file to match the Microsoft Open Source Team standard. Resolves issue #61 Oct 29, 2018
Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @timhaintz)


LICENSE, line 1 at r1 (raw file):

    MIT License

Can you remove the indentation from the file?

@timhaintz
Copy link
Contributor Author

@PlagueHO did you want the whole file indentation removed or just the MIT License line? @johlju mentioned in Issue 460 about the indentation. Happy to change it to how you would like it.
Thanks, Tim.

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right - didn't notice the mention of the indentation - very good point! I guess I have to update the other ones I've already done 😢

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO
Copy link
Member

Something has gone strange with the CI in AppVeyor. It has been running for 2 hours. When it times out, I'll close and reopen the PR to kick it again. Hopefully there isn't an issue with AppVeyor.

@timhaintz
Copy link
Contributor Author

@PlagueHO I will go through all the DSC Resources top to bottom. Any that aren't the same as the new standard, I will submit a PR for. I left line break at the end of this one as yours already had it. You happy with the line break at the end or would you like it removed?
Thanks for your help.

@johlju
Copy link
Member

johlju commented Oct 29, 2018

@PlagueHO Don't think the indentation is necessary, not seeing the need to change it if you added the file without indentation. The text is the important part 😉

@PlagueHO
Copy link
Member

Hehe @johlju - that is good to know 😁 So no worries about removing the indent @timhaintz from the existing ones (unless you really really wanted to 😁)

@PlagueHO PlagueHO closed this Oct 30, 2018
@PlagueHO PlagueHO reopened this Oct 30, 2018
@PlagueHO
Copy link
Member

PlagueHO commented Oct 30, 2018

Kicking the CI.

@codecov-io
Copy link

Codecov Report

Merging #63 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff        @@
##           dev   #63   +/-   ##
=================================
  Coverage   92%   92%           
=================================
  Files        5     5           
  Lines      373   373           
=================================
  Hits       346   346           
  Misses      27    27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants