-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActiveDirectoryCSDsc:Update LICENSE file to match the Microsoft Open Source Team standard. Resolves issue #61 #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @timhaintz)
LICENSE, line 1 at r1 (raw file):
MIT License
Can you remove the indentation from the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right - didn't notice the mention of the indentation - very good point! I guess I have to update the other ones I've already done 😢
Reviewable status:
complete! all files reviewed, all discussions resolved
Something has gone strange with the CI in AppVeyor. It has been running for 2 hours. When it times out, I'll close and reopen the PR to kick it again. Hopefully there isn't an issue with AppVeyor. |
@PlagueHO I will go through all the DSC Resources top to bottom. Any that aren't the same as the new standard, I will submit a PR for. I left line break at the end of this one as yours already had it. You happy with the line break at the end or would you like it removed? |
@PlagueHO Don't think the indentation is necessary, not seeing the need to change it if you added the file without indentation. The text is the important part 😉 |
Hehe @johlju - that is good to know 😁 So no worries about removing the indent @timhaintz from the existing ones (unless you really really wanted to 😁) |
Kicking the CI. |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is