Fix prepared statement error

pom.xml

@@ -24,7 +24,7 @@
 
     <groupId>io.r2dbc</groupId>
     <artifactId>r2dbc-mssql</artifactId>
-    <version>1.1.0.BUILD-SNAPSHOT</version>
+    <version>1.0.2.DSB</version>
     <packaging>jar</packaging>
 
     <name>Reactive Relational Database Connectivity - Microsoft SQL Server</name>
@@ -33,23 +33,22 @@
 
     <properties>
         <assertj.version>3.23.1</assertj.version>
-        <blockhound.version>1.0.6.RELEASE</blockhound.version>
         <hikari-cp.version>4.0.3</hikari-cp.version>
         <java.version>1.8</java.version>
         <jsr305.version>3.0.2</jsr305.version>
         <junit.version>5.9.1</junit.version>
         <jmh.version>1.33</jmh.version>
         <mbr.version>0.3.0.RELEASE</mbr.version>
         <logback.version>1.2.11</logback.version>
-        <mockito.version>4.8.1</mockito.version>
-        <mssql-jdbc.version>11.1.2.jre8-preview</mssql-jdbc.version>
+        <mockito.version>4.11.0</mockito.version>
+        <mssql-jdbc.version>12.2.0.jre8</mssql-jdbc.version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <r2dbc-spi.version>1.0.0.RELEASE</r2dbc-spi.version>
-        <r2dbc-pool.version>1.0.0.RELEASE</r2dbc-pool.version>
-        <reactor.version>2022.0.0</reactor.version>
-        <spring-framework.version>5.3.23</spring-framework.version>
-        <testcontainers.version>1.17.5</testcontainers.version>
+        <r2dbc-pool.version>1.0.1.RELEASE</r2dbc-pool.version>
+        <reactor.version>2022.0.9</reactor.version>
+        <spring-framework.version>5.3.29</spring-framework.version>
+        <testcontainers.version>1.18.3</testcontainers.version>
     </properties>
 
     <licenses>
@@ -135,12 +134,6 @@
             <artifactId>reactor-test</artifactId>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>io.projectreactor.tools</groupId>
-            <artifactId>blockhound</artifactId>
-            <version>${blockhound.version}</version>
-            <scope>test</scope>
-        </dependency>
         <dependency>
             <groupId>io.r2dbc</groupId>
             <artifactId>r2dbc-spi-test</artifactId>
@@ -216,7 +209,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.10.1</version>
+                <version>3.11.0</version>
                 <configuration>
                     <showWarnings>true</showWarnings>
                     <source>${java.version}</source>
@@ -243,12 +236,12 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-deploy-plugin</artifactId>
-                <version>3.0.0</version>
+                <version>3.1.1</version>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-enforcer-plugin</artifactId>
-                <version>3.1.0</version>
+                <version>3.3.0</version>
                 <executions>
                     <execution>
                         <id>enforce-no-snapshots</id>
@@ -269,7 +262,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-javadoc-plugin</artifactId>
-                <version>3.4.1</version>
+                <version>3.5.0</version>
                 <configuration>
                     <excludePackageNames>
                         io.r2dbc.mssql.authentication,io.r2dbc.mssql.client,io.r2dbc.mssql.codec,io.r2dbc.mssql.message,io.r2dbc.mssql.util
@@ -292,7 +285,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-source-plugin</artifactId>
-                <version>3.2.1</version>
+                <version>3.3.0</version>
                 <executions>
                     <execution>
                         <id>attach-javadocs</id>
@@ -305,7 +298,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>
-                <version>2.22.2</version>
+                <version>3.1.2</version>
                 <configuration>
                     <runOrder>random</runOrder>
                     <excludes>
@@ -320,7 +313,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-failsafe-plugin</artifactId>
-                <version>2.22.2</version>
+                <version>3.1.2</version>
                 <executions>
                     <execution>
                         <goals>
@@ -341,7 +334,7 @@
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>flatten-maven-plugin</artifactId>
-                <version>1.3.0</version>
+                <version>1.5.0</version>
                 <executions>
                     <execution>
                         <id>flatten</id>
@@ -388,22 +381,6 @@
 
     <profiles>
 
-        <profile>
-            <id>java18-blockhound</id>
-            <activation>
-                <jdk>1.8</jdk>
-            </activation>
-
-            <dependencies>
-                <dependency>
-                    <groupId>io.projectreactor.tools</groupId>
-                    <artifactId>blockhound-junit-platform</artifactId>
-                    <version>${blockhound.version}</version>
-                    <scope>test</scope>
-                </dependency>
-            </dependencies>
-        </profile>
-
         <profile>
             <id>jmh</id>
             <dependencies>
@@ -517,7 +494,7 @@
                         <plugin>
                             <groupId>org.apache.maven.plugins</groupId>
                             <artifactId>maven-gpg-plugin</artifactId>
-                            <version>3.0.1</version>
+                            <version>3.1.0</version>
                             <executions>
                                 <execution>
                                     <id>sign-artifacts</id>
@@ -547,7 +524,6 @@
                                 <nexusUrl>https://oss.sonatype.org/</nexusUrl>
                                 <autoReleaseAfterClose>false</autoReleaseAfterClose>
                                 <keepStagingRepositoryOnFailure>true</keepStagingRepositoryOnFailure>
-                                <skipStagingRepositoryClose>true</skipStagingRepositoryClose>
                             </configuration>
                         </plugin>
                     </plugins>

src/jmh/java/io/r2dbc/mssql/codec/BinaryCodecBenchmarks.java

@@ -75,13 +75,13 @@ public Encoded encodeByteBuffer() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, byte[].class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/BooleanCodecBenchmarks.java

@@ -57,13 +57,13 @@ public Encoded encode() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, Boolean.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/ByteCodecBenchmarks.java

@@ -57,13 +57,13 @@ public Encoded encode() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, Byte.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/DecimalCodecBenchmarks.java

@@ -61,13 +61,13 @@ public Encoded encode() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, BigDecimal.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/DoubleCodecBenchmarks.java

@@ -65,13 +65,13 @@ public Encoded encode() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, Double.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/IntegerCodecBenchmarks.java

@@ -57,13 +57,13 @@ public Encoded encode() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, Integer.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/LocalDateCodecBenchmarks.java

@@ -61,13 +61,13 @@ public Encoded encode() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, LocalDate.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/LocalDateTimeCodecBenchmarks.java

@@ -84,13 +84,13 @@ public Encoded encode() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, LocalDateTime.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/LocalTimeCodecBenchmarks.java

@@ -61,13 +61,13 @@ public Encoded encode() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, LocalTime.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/LongCodecBenchmarks.java

@@ -57,13 +57,13 @@ public Encoded encode() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, Long.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/ShortCodecBenchmarks.java

@@ -57,13 +57,13 @@ public Encoded encode() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, Short.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/StringCodecBenchmarks.java

@@ -122,13 +122,13 @@ public String decodeUuid() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(TestByteBufAllocator.TEST, String.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Collation collation, Object value) {
         Encoded encoded = codecs.encode(TestByteBufAllocator.TEST, RpcParameterContext.in(ValueContext.character(collation, true)), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/jmh/java/io/r2dbc/mssql/codec/UuidCodecBenchmarks.java

@@ -61,13 +61,13 @@ public Encoded encode() {
     @Benchmark
     public Encoded encodeNull() {
         Encoded encoded = codecs.encodeNull(alloc, UUID.class);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 
     private Encoded doEncode(Object value) {
         Encoded encoded = codecs.encode(alloc, RpcParameterContext.in(), value);
-        encoded.release();
+        encoded.dispose();
         return encoded;
     }
 }

src/main/java/io/r2dbc/mssql/Binding.java

@@ -79,8 +79,8 @@ boolean hasOutParameters() {
     void clear() {
 
         this.parameters.forEach((s, parameter) -> {
-            while (parameter.encoded.refCnt() > 0) {
-                parameter.encoded.release();
+            if (!parameter.encoded.isDisposed()) {
+                parameter.encoded.dispose();
             }
         });
 

src/main/java/io/r2dbc/mssql/ConnectionOptions.java

@@ -17,6 +17,7 @@
 package io.r2dbc.mssql;
 
 import io.r2dbc.mssql.codec.Codecs;
+import io.r2dbc.mssql.codec.DefaultCodecs;
 import reactor.util.annotation.Nullable;
 
 import java.time.Duration;
@@ -37,6 +38,10 @@ class ConnectionOptions {
 
     private volatile Duration statementTimeout = Duration.ZERO;
 
+    ConnectionOptions() {
+        this(sql -> false, new DefaultCodecs(), new IndefinitePreparedStatementCache(), true);
+    }
+
     ConnectionOptions(Predicate<String> preferCursoredExecution, Codecs codecs, PreparedStatementCache preparedStatementCache, boolean sendStringParametersAsUnicode) {
         this.preferCursoredExecution = preferCursoredExecution;
         this.codecs = codecs;