Always expect an event to be passed to subscribers. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From what I can understand, the previous behaviour passed the event through - but, because of `Dry::Events::Event#[]`, it could be implicitly converted into keyword arguments. With Ruby 3 no longer making implicit conversions of keyword arguments, I don't see this old behaviour as feasible - instead, the built-in subscribers should instead expect the event object, and get the particular keyed values out from it.
|
Thanks. This is definitely something that should be addressed before 1.0.0 release. I'll keep this open for the time being because it's a breaking change that should be coordinated with other people. |
|
Looks like this was addressed in main via ce652f2. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can understand, the previous behaviour passed the event through - but, because of
Dry::Events::Event#[], it could be implicitly converted into keyword arguments.With Ruby 3 no longer making implicit conversions of keyword arguments, I don't see this old behaviour as feasible - instead, the built-in subscribers should instead expect the event object, and get the particular keyed values out from it.
I'm not sure how significant a change this is, but I can foresee it breaking usage for others if they're using keyword arguments in their subscribers. I also note that there's been detailed discussions around payloads in #32 - perhaps this PR is moot depending on how that plays out? 🤷🏻♂️