Add exceptions to @future_safe; deprecate FutureResultE #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure about quality of PR and deleting FutureResultE, but project is in beta, kinda breaking changes are allowed I guess |
sobolevn
reviewed
Jul 21, 2024
CHANGELOG.md
Outdated
| @@ -10,6 +10,8 @@ See [0Ver](https://0ver.org/). | |||
|
|
|||
| ### Features | |||
|
|
|||
| - Add picky exceptions to `future_safe` decorator like `safe` has. | |||
| - Remove FutureResultE | |||
There was a problem hiding this comment.
Please, don't remove it just yet. Let's first provide an alternative. Moreover, maintaining an alias is simple enough.
Comment on lines
61
to
63
| future_instance = _coro_three('0') | ||
|
|
||
| await future_instance |
There was a problem hiding this comment.
Suggested change
| future_instance = _coro_three('0') | |
| await future_instance | |
| await _coro_three('0') |
| future_instance = _coro_two(0) | ||
|
|
||
| assert isinstance(future_instance, FutureResult) | ||
| assert isinstance(await future_instance, IOFailure) |
There was a problem hiding this comment.
We need to check that IOFailure has an expected error.
| ) -> int: | ||
| return 1 | ||
|
|
||
| reveal_type(test) # N: Revealed type is "def (first: builtins.int, second: Union[builtins.str, None] =, *, kw: builtins.bool =) -> returns.future.FutureResult[builtins.int, builtins.Exception]" |
There was a problem hiding this comment.
It should be:
Suggested change
| reveal_type(test) # N: Revealed type is "def (first: builtins.int, second: Union[builtins.str, None] =, *, kw: builtins.bool =) -> returns.future.FutureResult[builtins.int, builtins.Exception]" | |
| reveal_type(test) # N: Revealed type is "def (first: builtins.int, second: Union[builtins.str, None] =, *, kw: builtins.bool =) -> returns.future.FutureResult[builtins.int, builtins.ValueError]" |
| ) -> int: | ||
| return 1 | ||
|
|
||
| reveal_type(test) # N: Revealed type is "def (first: builtins.int, second: Union[builtins.str, None] =, *, kw: builtins.bool =) -> returns.future.FutureResult[builtins.int, builtins.Exception]" |
There was a problem hiding this comment.
Suggested change
| reveal_type(test) # N: Revealed type is "def (first: builtins.int, second: Union[builtins.str, None] =, *, kw: builtins.bool =) -> returns.future.FutureResult[builtins.int, builtins.Exception]" | |
| reveal_type(test) # N: Revealed type is "def (first: builtins.int, second: Union[builtins.str, None] =, *, kw: builtins.bool =) -> returns.future.FutureResult[builtins.int, builtins.ValueError]" |
|
I will help you with that! Thanks! |
sobolevn
changed the title
sobolevn
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1880 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 80 80
Lines 2485 2523 +38
Branches 437 446 +9
=========================================
+ Hits 2485 2523 +38 ☔ View full report in Codecov by Sentry. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added exceptions to @future_safe; removed FutureResultE
Checklist
CHANGELOG.mdRelated issues