Suggest ext-pcntl in composer.json #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, we only require it if you actually use the finder. You are welcome to use the wrapper or launcher directly AFAIK. So maybe this should be 'suggest'? I'm concerned that fixing this will be a hassle for people and they really dont have to. |
|
Note that since finder is the default script, the first experience after updating to latest is a "function not found" error. In this scenario, 'suggest' is helpful the same degree. I'll change the commit and merge. |
jonhattan
force-pushed
the
composer-pcntl
branch
from
2c293f0
to
34ab75e
Compare
jonhattan
added a commit
that referenced
this pull request
Oct 1, 2015
Suggest ext-pcntl in composer.json. Needed by drush finder script.
jonhattan
changed the title
|
Just run into this problem as all my infrastructure is glued with Docker libraries. It looks like I should wait for the fall back solution mentioned in #1595 (comment) ? Currently, Docker official library doesn't support Composer docker-library/drupal#7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1595 we rely on pcntl_exec(). Some php binaries are not compiled with it (ex https://github.com/docker-library/php). Adding an explicit dependency in composer.json helps identifying the problem.