Issue #2846890: Create a log entry when item is removed from cart or qty is changed programatically #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…qty is changed programatically
steveoliver
reviewed
Feb 1, 2017
| cart_item_quantity_changed: | ||
| category: commerce_cart | ||
| label: 'Quantity changed from cart' | ||
| template: '<p>Quantity for <em>{{ purchased_entity_label }}</em> changed in the cart form <em>{{ original_quantity }} to {{ quantity }}</em>.</p>' |
There was a problem hiding this comment.
Change "Quantity for" to "Quantity of".
No emphasis around the quantities.
And "form" should be "from".
|
This looks good, @GoZOo - think you could create a test for this in https://github.com/drupalcommerce/commerce/blob/8.x-2.x/modules/log/tests/src/Kernel/CartIntegrationTest.php ? Then I'd say this is good to go. |
|
You are right, I completely miss the tests |
|
Note that we'll have to update this PR or #628 depending of witch one is commited first. |
|
Needs work. See last fail. |
bojanz
force-pushed
the
8.x-2.x
branch
7 times, most recently
from
6be1d5c
to
b8a7444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue https://www.drupal.org/node/2846890