-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataproducer): make access check optional in entity_label (#1382) #1383
base: 8.x-4.x
Are you sure you want to change the base?
feat(dataproducer): make access check optional in entity_label (#1382) #1383
Conversation
I'll try to fix the tests |
BTW this is related to https://www.drupal.org/sa-contrib-2023-050 |
The issue with the tests is actually a bug in DataProducerExecutionTrait and has an issue for it: #1233 DataProducerExecutionTrait does not care about the dafault value, so it needs to be specified. I just made a workarround for the tests with a todo that marks that the 'access' default value can be removed after that issue is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, i think this requires a bit of tweaking and a new test case where we demonstrate that access checking is ignored when this parameter is set to FALSE.
85377f7
to
b1c88c8
Compare
Fixes #1382