Skip to content

Always add the list cache tags otherwise if list is not empty and you… #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 8.x-4.x
Choose a base branch
from
Open

Always add the list cache tags otherwise if list is not empty and you… #1101

wants to merge 2 commits into from

Conversation

dmitrypro77
Copy link

Always add the list cache tags otherwise if list is not empty and you create a new term, you will not able to see created term in the list.

Always add the list cache tags otherwise if list is not empty and you…
290093d 
… create a new term, you will not able to see it in list
stevenspasbo
stevenspasbo reviewed Oct 30, 2020
View reviewed changes
Copy link

@stevenspasbo stevenspasbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

klausi
klausi requested changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@klausi klausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think that make sense!

Can you add a data producer test for this class so that we verify this behavior? We are lacking test coverage for this, so would be good to cover this to prevent regressions in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenspasbo stevenspasbo stevenspasbo left review comments

@klausi klausi klausi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
4.x needs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitrypro77 @klausi @stevenspasbo @BalintCsuthy