fix: renderCustomElements is not bullet-proof #280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to improve our default node component to use the proper slot syntax (as documented) I ran into problems with rendering custom elements erroring out.. Let's fix this by making the helper real-bullet-proof and properly documented.
It should work like this
However, it dies if
Current work-a-roudn is really not nice and not what we want to keep:
Let's fix this, so renderCustomElements can be used without hassle / lots of needs the passed data is an object.