Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(object): linearize pair semantic #476

Merged
merged 2 commits into from
Feb 17, 2025
Merged

refactor(object): linearize pair semantic #476

merged 2 commits into from
Feb 17, 2025

Conversation

sfroment
Copy link
Member

  • refactor: 🎨 linearize pair simpler
  • test: add missing test for multiple semantics

What type of PR is this?

  • Refactor

Description

Added/updated tests?

  • Yes

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

@github-actions GitHub Actions
Copy link

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

JanLewDev
JanLewDev approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfroment sfroment merged commit a6c4705 into main Feb 17, 2025
14 checks passed
@sfroment sfroment deleted the refactor/linearize branch February 17, 2025 13:17
hoangquocvietuet pushed a commit that referenced this pull request Feb 18, 2025
@sfroment @hoangquocvietuet
refactor(object): linearize pair semantic (#476)
8ffdcec
sfroment added a commit that referenced this pull request Feb 19, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into fix/duplicate-drp-call
84e480f 
* origin/main:
  fix: dialTimeout (#484)
  fix: serialization & add types pkg (#472)
  feat: deterministic topo sort using iterative dfs (#471)
  refactor(object): linearize pair semantic (#476)
  refactor: remove unuse transport (#466)
  fix: pr template (#464)
sfroment added a commit that referenced this pull request Feb 19, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into fix/duplicate-drp-call
48ef774 
* origin/main:
  fix: dialTimeout (#484)
  fix: serialization & add types pkg (#472)
  feat: deterministic topo sort using iterative dfs (#471)
  refactor(object): linearize pair semantic (#476)
  refactor: remove unuse transport (#466)
  fix: pr template (#464)

Signed-off-by: Sacha Froment <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanLewDev JanLewDev JanLewDev approved these changes

@trungnotchung trungnotchung Awaiting requested review from trungnotchung trungnotchung is a code owner

@winprn winprn Awaiting requested review from winprn winprn is a code owner

@hoangquocvietuet hoangquocvietuet Awaiting requested review from hoangquocvietuet

@magnified103 magnified103 Awaiting requested review from magnified103 magnified103 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfroment @JanLewDev