Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deterministic topo sort using iterative dfs #471

Merged
merged 5 commits into from
Feb 18, 2025
Merged

feat: deterministic topo sort using iterative dfs #471

merged 5 commits into from
Feb 18, 2025

Conversation

JanLewDev
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Feature

Description

Make

Related Issues and PRs

Added/updated tests?

  • Yes

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

@trungnotchung
Copy link
Member

why are we changing from kahnsAlgorithm to dfs. can't just sort neighbors fix the issue?

@JanLewDev
Copy link
Contributor Author

why are we changing from kahnsAlgorithm to dfs. can't just sort neighbors fix the issue?

this pr also solves #470

sfroment
sfroment requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@sfroment sfroment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's discuss this part

trungnotchung
trungnotchung reviewed Feb 17, 2025
View reviewed changes
@trungnotchung
Copy link
Member

i think we should add some tests for the case graph contains a cycle

trungnotchung
trungnotchung approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfroment sfroment merged commit 5e08e18 into main Feb 18, 2025
14 checks passed
sfroment added a commit that referenced this pull request Feb 19, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into fix/duplicate-drp-call
84e480f 
* origin/main:
  fix: dialTimeout (#484)
  fix: serialization & add types pkg (#472)
  feat: deterministic topo sort using iterative dfs (#471)
  refactor(object): linearize pair semantic (#476)
  refactor: remove unuse transport (#466)
  fix: pr template (#464)
sfroment added a commit that referenced this pull request Feb 19, 2025
@sfroment
Merge remote-tracking branch 'origin/main' into fix/duplicate-drp-call
48ef774 
* origin/main:
  fix: dialTimeout (#484)
  fix: serialization & add types pkg (#472)
  feat: deterministic topo sort using iterative dfs (#471)
  refactor(object): linearize pair semantic (#476)
  refactor: remove unuse transport (#466)
  fix: pr template (#464)

Signed-off-by: Sacha Froment <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfroment sfroment sfroment approved these changes

@trungnotchung trungnotchung trungnotchung approved these changes

@winprn winprn Awaiting requested review from winprn winprn is a code owner

@hoangquocvietuet hoangquocvietuet Awaiting requested review from hoangquocvietuet hoangquocvietuet is a code owner

@magnified103 magnified103 Awaiting requested review from magnified103 magnified103 is a code owner

@d-roak d-roak Awaiting requested review from d-roak d-roak is a code owner

@anhnd350309 anhnd350309 Awaiting requested review from anhnd350309 anhnd350309 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Use iterative dfs for topological sort
3 participants
@JanLewDev @trungnotchung @sfroment