Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flamegraph pprof #453

Merged
merged 16 commits into from
Feb 12, 2025
Merged

feat: flamegraph pprof #453

merged 16 commits into from
Feb 12, 2025

Conversation

anhnd350309
Copy link
Contributor

@anhnd350309 anhnd350309 commented Feb 10, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • Feature

Description

Add pprof for performance profiling and generating flame graphs to analyze application performance.

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • No, because why: Initial implementation of pprof integration does not require immediate test changes

Additional Info

@anhnd350309 anhnd350309 marked this pull request as ready for review February 10, 2025 12:01
@d-roak d-roak changed the title Feat/flamegraph pprof feat: flamegraph pprof Feb 10, 2025
@drp-tech drp-tech deleted a comment from github-actions bot Feb 11, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

d-roak
d-roak reviewed Feb 11, 2025
View reviewed changes
trungnotchung
trungnotchung approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak merged commit f9f9c6c into main Feb 12, 2025
14 checks passed
sfroment pushed a commit that referenced this pull request Feb 13, 2025
@anhnd350309 @sfroment
feat: flamegraph pprof (#453)
f1846f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-roak d-roak d-roak approved these changes

@trungnotchung trungnotchung trungnotchung approved these changes

@JanLewDev JanLewDev Awaiting requested review from JanLewDev JanLewDev is a code owner

@winprn winprn Awaiting requested review from winprn winprn is a code owner

@hoangquocvietuet hoangquocvietuet Awaiting requested review from hoangquocvietuet hoangquocvietuet is a code owner

@magnified103 magnified103 Awaiting requested review from magnified103 magnified103 is a code owner

@sfroment sfroment Awaiting requested review from sfroment sfroment is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anhnd350309 @d-roak @trungnotchung