feat: use msgpack #450
Merged
feat: use msgpack #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sacha Froment <[email protected]>
sfroment
requested review from
JanLewDev,
trungnotchung,
winprn,
hoangquocvietuet and
magnified103
as code owners
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
sfroment
force-pushed
the
fix/serialization
branch
from
fb427e8 to
7133062
Compare
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
sfroment
changed the title
Flamegraph.com reportCreated by Flamegraph.com Github Action |
sfroment
added a commit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Sacha Froment <[email protected]> Co-authored-by: hoangquocvietuet <[email protected]> Co-authored-by: droak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For map and object you don't know what the values are.
So in reality if you take the example of the authorizedPeers it's a map containing Sets so it won't be serialized the way we want it if we don't make those recursive call.
Also we should go tail recursive on this one and each recursive call of this function otherwise we might encounter recursive stack limitation problem.
Will add unit test for this ASAP, but this nevertheless need to be merged,
Signed-off-by: Sacha Froment [email protected]