fix: need to spread the object otherwise you loose the config #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sacha Froment <[email protected]>
d-roak
reviewed
Aug 21, 2024
| @@ -38,7 +38,7 @@ export class TopologyNode { | |||
| }; | |||
| } | |||
| if(!this._config.network_config?.tslog_config){ | |||
| this._config.network_config = { tslog_config: this._config?.tslog_config }; | |||
| this._config.network_config = { ...this._config.network_config, tslog_config: this._config?.tslog_config }; | |||
There was a problem hiding this comment.
didn't noticed. what do you think its better?
this._config.network_config = { ...this._config.network_config, tslog_config: this._config?.tslog_config };
or
this._config.network_config.tslog_config = this._config?.tslog_config
There was a problem hiding this comment.
I prefer the latest as we won't recreate the object, but there we can't as at this point in the code we don't know if this._config.network_config is not undefined, so we'll have to go for the 1st one if we aren't willing to add
if (!this._config.network_config?.tslog_config) {
if (!this._config.network_config) this._config.network_config = {};
this._config.network_config.tslog_config = this._config?.tslog_config;
}There was a problem hiding this comment.
We can go with it, all good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to spread the object otherwise you'll loose the config assign before