MF-5759 fix stability of namespace route sorting #548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went with sorting the routes in place just before we started generating a given namespace.
I would've preferred to have a stronger guarantee that routes are always sorted by doing an insort in the add_route method https://github.com/dropbox/stone/blob/83da417f780b40750b2fd6cdb9697e395cc1dd40/stone/ir/api.py#L128, but since this is even further upstream there's a barrier there.
Also just to call out there's an existing attempt to sort routes as they're added here https://github.com/dropbox/stone/blob/83da417f780b40750b2fd6cdb9697e395cc1dd40/stone/frontend/ir_generator.py#L1709 but it looks to not be sufficient.