Updates android library to be a proper android library. #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
dropbox-sdk-androidmodules from simply an included source set into a proper Android module.Since the splitting of the Java and Android modules will be a large breaking change for many consumers if we continue using the
dropbox-sdk-javaartifact ID and they simply update the version, I propose that when we make this split (in 6.0.0) we use different artifact names. I'm thinkingdropboxanddropbox-android, modeled after a similar approach for OkHTTP.That will mean that instead of blindly updating the version from 5.x to 6.x and losing any of the Android goodness, consumers will have to actually update the artifact id to move, forcing them to choose the right one. That will come in a later PR.