-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An attempt to add cancellation token to async methods (#41) #209
base: main
Are you sure you want to change the base?
An attempt to add cancellation token to async methods (#41) #209
Conversation
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 10.17% 10.17% -0.01%
==========================================
Files 17 17
Lines 1572 1573 +1
==========================================
Hits 160 160
- Misses 1412 1413 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi @greg-db |
Thanks for putting this together! I'm not the right person to do the actual review, but I'll ask the team to review this when they can. |
Thanks, @greg-db! |
Hi @greg-db @connorworley |
@AlirezaMaddah This is still open with the team, but I don't have an update on this right now. |
…om/AlirezaMaddah/dropbox-sdk-dotnet into addCancellationTokenToAsyncMethods
Alireza Maddah seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This is an attempt to add cancellation capability to async methods by adding the CancellationToken optional argument as follows:
Checklist
General Contributing
Is This a Code Change?
Validation