Multiframe transfer assert expression correction #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradAPD
force-pushed
the
pr-multiframe-assert-criteria-revision
branch
from
1dc4796
to
c14f03d
Compare
…r a valid operation. Modifying underflow assert check. This check mistakenly invalidates the case where the final CAN frame of a transfer is received with all previously allocated memory blocks fully utilised.
tridge
force-pushed
the
pr-multiframe-assert-criteria-revision
branch
from
c14f03d
to
f770569
Compare
|
this change looks correct, but I'd like @bugobliterator to comment |
bugobliterator
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies an assert check targeting an underflow condition in multi-frame transfer receive processing. The assert aims to detect accidental underflow in a memory offset computation. The assert expression mistakenly invalidates a case where the final CAN frame of a transfer is received with all previously allocated memory blocks fully utilised. This condition requires the base address of the frame data buffer to be assigned to the
rx_transfer.payload_tailfield.The assert case is triggerable by performing a multi-transfer file read operation using the DroneCAN GUI tool, such as during a firmware update process. The CAN bus is configured in non-CAN-FD mode, with the default memory allocator block size of 32 bytes.