Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Buffered CAN Frames #25

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add support for Buffered CAN Frames #25

wants to merge 16 commits into from
+1,215 −12,459

Conversation

bugobliterator
Copy link
Collaborator

@bugobliterator bugobliterator commented Apr 15, 2023 •
edited
Loading

  • moves to add api to use TxTransfer objects instead of passing all the info through function arguments.
  • retains backward compatibility with existing apis albeit with bit more flash cost.

This is done to simplify additions/modifications to the options passed to transmit data.

@bugobliterator bugobliterator force-pushed the pr-buffered-tx-frame branch 6 times, most recently from 08353cd to 0134f63 Compare April 15, 2023 14:37
@bugobliterator bugobliterator force-pushed the pr-buffered-tx-frame branch 5 times, most recently from 4d9fff4 to b201837 Compare April 16, 2023 05:07
tridge
tridge requested changes Jun 4, 2023
View reviewed changes
Copy link
Member

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rebase

@tridge
Copy link
Member

tridge commented Aug 31, 2023

@bugobliterator do we still want this?

@bugobliterator
Copy link
Collaborator Author

@bugobliterator do we still want this?

Yes, I just need to find time to finish this. Having this will let us have lower RAM footprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugobliterator @tridge