-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added link stats packet #33
Open
David-OConnor
wants to merge
8
commits into
dronecan:master
Choose a base branch
from
David-OConnor:add-link-stats
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4fb4d23
Added link stats packet
David-OConnor 4726e55
Fixed error
David-OConnor da39c06
Change to LQ and RSSI descriptions
David-OConnor d84dd8f
More updates
David-OConnor 21fc264
Added uplink active antenna
David-OConnor 39f5713
Update
David-OConnor fbbf89d
typo
David-OConnor 6cfa8b9
Added downlink rssi 2
David-OConnor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,39 @@ | ||||||
# | ||||||
# This definition describes metadata and statistics for a RF control link. | ||||||
# It provides information regarding a link's signal quality, as well as transmitter | ||||||
# power, and antenna information. It accomodates single-radio, and dual-radio | ||||||
# link architectures. It provides information for both uplink (control unit to airborne | ||||||
# receiver), and downlink (airborne receiver to control unit) data. | ||||||
# | ||||||
|
||||||
uint8 STATUS_RSSI_VALID = 1 # RSSI field is valid | ||||||
|
||||||
# Uplink - received signal strength, in decibel-milliwatts (RSSI dBm) for antennas 1 and 2 respectively. | ||||||
# Ranges from # -255 to 0. (An integer value of 100 means RSSI is -100dBm) | ||||||
uint8 uplink_rssi_1 | ||||||
uint8 uplink_rssi_2 | ||||||
|
||||||
# Link quality, on a scale from 1 to 255. Is a proxy for packet loss. 0 means data is unavailable. 1 and 255 are mapped to 0% and 100% of packets received. | ||||||
uint8 uplink_link_quality | ||||||
|
||||||
David-OConnor marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
# Signal-to-noise ratio. | ||||||
int8 uplink_snr | ||||||
|
||||||
# This is an implementation-specific enum. May represent the OTA protocol used, | ||||||
# and transmission rate. | ||||||
uint8 rf_mode | ||||||
|
||||||
# This is an implementation-specific enum describing the current transmitter nominal | ||||||
# power level. | ||||||
uint8 uplink_tx_power | ||||||
|
||||||
# Statistics for downlink data, ie telemetry. See their respective `uplink` fields for | ||||||
# descriptions. | ||||||
uint8 downlink_rssi | ||||||
David-OConnor marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
uint8 downlink_link_quality | ||||||
int8 downlink_snr | ||||||
|
||||||
# Active antenna on transmitter and receiver. Example: 1 for antenna 1, and 2 for antenna 2. | ||||||
# Not applicable for single-antenna links. | ||||||
uint8 tx_active_antenna | ||||||
uint8 Rx_active_antenna | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consistency
Suggested change
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version would align with MAVLink better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@David-OConnor Can we swap to this pattern?