Pass parameters to promote/rollback as querystring #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom build params are ignored when sent on the POST body and need to be attached to the querystring. Modify the promote and rollback functions to ensure that the params are sent in a way that is recognised by the Drone server.
|
Note: I haven't been able to update any of the unit tests since it appears the existing test suite runs against an actual live Drone instance, so it is not reasonable to test build promotions with parameters in this way. |
tboerger
reviewed
Nov 22, 2020
| params | ||
| ) | ||
| ) | ||
| `/api/repos/${owner}/${repo}/builds/${number}/rollback/${qs}` |
There was a problem hiding this comment.
The last slash should be a questionmark, right?
|
I've recently run into this bug of params not being passed to the promote command via this lib. Hey @lennym would you be up for making the small adjustment mentioned above in this PR? If not, no worries, I'd be happy to open another PR with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom build params are ignored when sent on the POST body and need to be attached to the querystring. Modify the promote and rollback functions to ensure that the params are sent in a way that is recognised by the Drone server.