Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PATH in Dockerfile Instead of Clone Script #42

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

julmb
Copy link

@julmb julmb commented Oct 15, 2021

This is based on PR #41.

In windows/clone.ps1 there is a comment

HACK: no clue how to set the PATH inside the Dockerfile, so am setting it here instead. This is not idea.

These changes set the PATH in the Dockerfile instead of in the windows/clone.ps1 script.

This has the added benefit of enabling the use of the drone/git image to use Git in a pipeline step on Windows (where there are no simple images like alpine/git).

- name: dependencies
  image: drone/git
  shell: pwsh
  commands:
  - git clone http://example.com/library.git

@marko-gacesa
Copy link

@julmb Thank you very much for this. But, but we can't merge this PR now because currently we don't have a Windows 2022 machine...

@julmb
Copy link
Author

julmb commented Feb 7, 2023

@julmb Thank you very much for this. But, but we can't merge this PR now because currently we don't have a Windows 2022 machine...

Judging from recent commits, there is now a Server 2022 machine in your CI system. Any chance of getting this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants