Adding Windows 2004

[luthermonson]

Added to support drone-plugins/drone-docker#284

For this to work fully it will need Windows 2004 hosts to build the images.

[luthermonson]

@bradrydzewski there's a weird one on this.... i got core dumps from servers when i used images built from this Dockerfile. It worked on almost all of our builds except one was a doozy so I'm just warning you that the fix for me was to remove all the nanoserver and leave everything in servercore. Wish I knew why that fixed it but after a LOT of head banging against a wall that's the only thing that did it for me.

[donny-dont]

Seems fine but can't merge until there's a builder

[luthermonson]

@donny-dont @bradrydzewski update on the BSOD or whatever issue... if you have a large repo this seems to be the cause during the git fetch process. I back traced it to pulling packfiles somewhere deep in git.exe and I don't think it's anything any of us are going to solve, seems like something for someone at msft or docker and I'm trying to push my dump files and logs to someone who might be able to fix it. the basics for running drone is this... you HAVE to set the DRONE_DEPTH to something small on larger repos or it will die a miserable death during the clone process.

This worked...

clone:
  disable: true

steps:
  - name: clone
    image: luthermonson/drone-git:windows-2004-amd64
    settings:
      depth: 1

Hope it helps you guys and hope you get a 2004 runner soon.

[donny-dont]

@luthermonson just curious but did you try a later git at all in this process? As of now we're up to git 2.29

[luthermonson]

@donny-dont yup, i did... it's not that so i reverted back to your version

[luthermonson]

@donny-dont @bradrydzewski with 12/9 container AMIs in Amazon this problem discussed has pretty much gone away and our builds are 100% consistent. We're merging and building 2004 containers every build going forward and will tell you if we have any more issues. im quite confident this was never drone and this PR should be merged. I will have 20h2 PRs shortly too

[donny-dont]

@luthermonson again the problem is there's no build for cloud.drone.io to do anything other than the current windows images. Also there is currently not a powershell 20H2 image, see PowerShell/PowerShell-Docker#523 which is still open. There's also the question of adding git-lfs which is in #28 so anyways we need to figure this all out. The images are all copy-pasta so maybe we should get some guidance from @bradrydzewski before going further here.

[luthermonson]

i fully understand the build servers are the issue for not merging this... that's not my problem. we have our own running with drone-git built in 2004 with no issues and I'm trying to relay they my confidence in 2004 + drone is high and you should get the servers and move forward. that's all i can do... let me check into your powershell comment

[luthermonson]

@donny-dont this Powershell stuff you linked is for the images in hub mcr.microsoft.com/powershell. nothing i did to get 2004 went near that container so I'm not sure it applies and re git-lfs that can still be added to the 2004/20h2 docker files. need hosts, that's the most important thing holding this up and a docker images for drone-runner and drone-git in docker hub.

[donny-dont]

@luthermonson you're using the powershell image as the base. All the scripts are powershell so there needs to be a 20H2 before you can do anything.

[luthermonson]

ah yes, indeed. you win so much copy pasta i didnt even notice. that's a shame but for my purposes ill just keep it a servercore, large image size doesnt bother me. for your purposes you are correct

[StillJodes]

@luthermonson just curious but did you try a later git at all in this process? As of now we're up to git 2.29

[StillJodes]

lols

[StillJodes]

[StillJodes]

[luthermonson]

@StillJodes yes i did try later versions from git for windows. as of nov/dec the 2004 AMI in windows no longer has this problem. It was some patch that had to come from msft to fix this it appears