feat: [CI-9882]: Removed private as Default value of ACL (#61)

* feat: [CI-9882]: removed private as default ACL * feat: [CI-9882]: comments resolved
drone-plugins · Nov 8, 2023 · e604755 · e604755
1 parent a1e2519
commit e604755
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/main.go b/main.go
@@ -375,7 +375,6 @@ func main() {
 		&cli.StringFlag{
 			Name:    "acl",
 			Usage:   "upload files with acl (private, public-read, ...)",
-			Value:   "private",
 			EnvVars: []string{"PLUGIN_ACL", "AWS_ACL"},
 		},
 		&cli.StringFlag{

diff --git a/storage/backend/s3/s3.go b/storage/backend/s3/s3.go
@@ -68,13 +68,18 @@ func New(l log.Logger, c Config, debug bool) (*Backend, error) {
 		client = s3.New(sess)
 	}
 
-	return &Backend{
+	backend := &Backend{
 		logger:     l,
 		bucket:     c.Bucket,
-		acl:        c.ACL,
 		encryption: c.Encryption,
 		client:     client,
-	}, nil
+	}
+
+	if c.ACL != "" {
+		backend.acl = c.ACL
+	}
+
+	return backend, nil
 }
 
 // Get writes downloaded content to the given writer.