Merge pull request #201 from droibit/feature/refactoring

Refactor code to suppress deprecation warnings
droibit · Jul 25, 2024 · ef0d092 · ef0d092
2 parents 892d414 + 103729a
commit ef0d092
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/...droid/src/main/java/com/github/droibit/flutter/plugins/customtabs/CustomTabsLauncher.java b/...droid/src/main/java/com/github/droibit/flutter/plugins/customtabs/CustomTabsLauncher.java
@@ -139,6 +139,7 @@ public void closeAllIfPossible() {
     /**
      * @noinspection SameParameterValue
      */
+    @SuppressWarnings("deprecation")
     private static @Nullable ResolveInfo resolveService(
             @NonNull PackageManager pm,
             @NonNull Intent intent,
@@ -150,7 +151,6 @@ public void closeAllIfPossible() {
                     PackageManager.ResolveInfoFlags.of(flags)
             );
         } else {
-            //noinspection deprecation
             return pm.resolveService(intent, flags);
         }
     }

diff --git a/...java/com/github/droibit/flutter/plugins/customtabs/core/options/BrowserConfiguration.java b/...java/com/github/droibit/flutter/plugins/customtabs/core/options/BrowserConfiguration.java
@@ -62,8 +62,9 @@ public Builder() {
         }
 
         /**
-         * @noinspection DataFlowIssue, unchecked
+         * @noinspection DataFlowIssue
          */
+        @SuppressWarnings("unchecked")
         public @NonNull Builder setOptions(@Nullable Map<String, Object> options) {
             if (options == null) {
                 return this;

diff --git a/...va/com/github/droibit/flutter/plugins/customtabs/core/options/CustomTabsColorSchemes.java b/...va/com/github/droibit/flutter/plugins/customtabs/core/options/CustomTabsColorSchemes.java
@@ -60,9 +60,7 @@ public static class Builder {
         public Builder() {
         }
 
-        /**
-         * @noinspection unchecked
-         */
+        @SuppressWarnings("unchecked")
         public @NonNull Builder setOptions(@NonNull Map<String, Object> options) {
             if (options.containsKey(KEY_COLOR_SCHEME)) {
                 colorScheme = (Integer) options.get(KEY_COLOR_SCHEME);

diff --git a/...a/com/github/droibit/flutter/plugins/customtabs/core/options/CustomTabsIntentOptions.java b/...a/com/github/droibit/flutter/plugins/customtabs/core/options/CustomTabsIntentOptions.java
@@ -100,8 +100,9 @@ public Builder() {
         }
 
         /**
-         * @noinspection unchecked, DataFlowIssue
+         * @noinspection DataFlowIssue
          */
+        @SuppressWarnings("unchecked")
         public @NonNull Builder setOptions(@NonNull Map<String, Object> options) {
             if (options.containsKey(KEY_COLOR_SCHEMES)) {
                 colorSchemes = new CustomTabsColorSchemes.Builder()