JP-3671: make OLS_C the default algorithm for ramp fitting (spacetele…

…scope#8607)
drlaw1558 · Jun 26, 2024 · c7fe27f · c7fe27f
1 parent 90f4d57
commit c7fe27f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -327,6 +327,8 @@ ramp_fitting
   fitting or "OLS_C" to use the C extension implementation of
   ramp fitting. [#8503]
 
+- Made "OLS_C" the default algorithm for ramp fitting. [#8607]
+
 refpix
 ------
 

diff --git a/docs/jwst/ramp_fitting/arguments.rst b/docs/jwst/ramp_fitting/arguments.rst
@@ -5,7 +5,7 @@ The ramp fitting step has the following optional arguments that can be set by th
 * ``--algorithm``: A string to select the desired algorithm.  The available
   values are "OLS" to select the python implementation of the Ordinary
   Least Squares algorithm and  "OLS_C" to select the C extension
-  implementation of OLS.  The algorithm defaults to "OLS".
+  implementation of OLS.  The algorithm defaults to "OLS_C".
 
 * ``--save_opt``: A True/False value that specifies whether to write
   the optional output product. Default is False.

diff --git a/jwst/ramp_fitting/ramp_fit_step.py b/jwst/ramp_fitting/ramp_fit_step.py
@@ -385,7 +385,7 @@ class RampFitStep(Step):
     class_alias = "ramp_fit"
 
     spec = """
-        algorithm = option('OLS', 'OLS_C', default='OLS') # Can be 'OLS_C' to select the C extension
+        algorithm = option('OLS', 'OLS_C', default='OLS_C') # 'OLS' and 'OLS_C' use the same underlying algorithm, but OLS_C is implemented in C
         int_name = string(default='')
         save_opt = boolean(default=False) # Save optional output
         opt_name = string(default='')
-Original file line number
+Diff line change
@@ Expand Up / @@ -327,6 +327,8 @@ ramp_fitting @@
       fitting or "OLS_C" to use the C extension implementation of
       ramp fitting. [#8503]
+    - Made "OLS_C" the default algorithm for ramp fitting. [#8607]
     refpix
     ------
@@ Expand Down @@