Simplify save_dir and some directory -> dir renames #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbull
reviewed
Oct 23, 2021
pjbull
requested changes
Oct 25, 2021
|
All discussed changes were implemented. Includes some additional fixes on looking up local or cached checkpoints, better validation for dry run and save, and fully updated train_config and predict_configs for the models. Ready for another review @pjbull All tests are passing locally and will be run on CI when merged into a branch that is PR'd into v2. |
pjbull
approved these changes
Oct 25, 2021
pjbull
pushed a commit
that referenced
this pull request
Oct 25, 2021
* add denspose and update save dir * commit two autogenerated files * changelog edits * contribute edits * WIP edits for models * finish edits for models and separate out densepose * full list of parks * config options * vscode format * move config guide into tutorials * extra options * windows not tested * tutorial edits * remove extra nb * put save path back * quickstart edits * vscode formatting * finish quickstart edits * train tutorial * add template section * logging * ffpmeg install in readme * finetuning * capitalization * remove ffmpmeg * date * add densepose * tweak * simplify * fix densepose video link * caps and tensorboard * add help * remove pythong piece since this is focused on yaml files * more tweaks * edit history not change log * copy edits * fix changelog * table * table * typo * alphabetize * table bug * table edits * Simplify save_dir and some directory -> dir renames (#151) * wip renames * renames in docs * readme * data dir renamme in docs * rename in code from data_directory to data_dir * maintaining update * fix capitalization * further updates * tweak * do not overwrite * add overwrite save dir * add overwrite save dir to config * update configs with all info * use full train configuration * only upload if does not exist * tests for save * overwrite param * better set up and test for overwrite * docs * update docs with overwrite * from overwrite_save_dir to overwrite * missed rename * remove machine specific from vlc * unindent so test actually runs * check for local and cached checkpoints * should be and * write out predict config before preds start like we do for train config * update all configs and use only first 10 digits of hash * dry run check after save is configured; more robust test * reorder * show save directory * copy edits * update template * fix test * lower case for consistency * fix test
pjbull
added a commit
that referenced
this pull request
Oct 26, 2021
* delete v1 * remove hidden files * Zamba v1 docs port (#108) * workflow tests * remove tests workflow from v2 * Great migration (#113) * copy everything * first round of deletion * more deletions * more deletions * put everything under zamba * remove old readme * replace zamba_algorithms with zamba * integrate makefile * changed files * updates from save dir overwrite * add gitignore * use gitignore from zamba algo * remove load metadata * remove old dirs * lint * remove load metadata * remove load_metadata test * fix datamodule tests * simplify time dist model since there is only one * flake8 * remove unused file * put back lost code * back to long name because that is was model is registered as * species is no longer on model * use models without species prefix and zamba backbone finetune params; * rename time dist head since there is only one * further remove species * use lstrip instead * passing tests * add missing underscore * update links to setup.cfg * specify branches in workflow * update setup.cfg * Update setup.cfg Co-authored-by: Peter Bull <[email protected]> * Update setup.cfg Co-authored-by: Peter Bull <[email protected]> Co-authored-by: Peter Bull <[email protected]> * bug fix (#114) * Skip on failure, actually drop duplicates, clarify logging (#115) * skip on failure, actually drop duplicates, clarify logging * correct comment * only apply to root validators * First draft of zamba v2 docs (#112) * Update zamba predict in cli doc * Update zamba train in cli doc * Formatting * Start updating index * Update ungulate pic * update to chimp image * specify image sizes * update image sizes * add labels to images * Format * add labels to frames * note about top div * start updating inputs_outputs * tweaks to index * Use new vids in index * use full size images * remove some todo notes * comments to cli md * comments to cli md * comments to cli md * Add comments to index * Comments to inputs_outputs * Incorporate preliminary comments * Start working on install * Start working on algorithms * Start reorganizing * Redo quickstart to have a python section * Add basics of slowfast * Use better compressed images * Try and view with new TOC * Add more model info * Start configuration documentation * Add all configurations * Update TOC with configurations doc page * Add where output is saved * Add placeholders for user tutorials * v2 updates * Add info about yolox * Send us labeled videos * Make available models top level * TODO about model details * Better explanation of YAML v CLI args * Copy edits and formatting * Update install page * Add basic use to available models * Update mkdocs.yml * Start working on python package page * Make TOC work correctly * Add explanation of more of the parameter options * Start user tutorials * Update based on new default help text * Copy editing * Add where to reference for python package * Remove repetitive parameter explanation from cli.md * Update TOC names * Update tutorial names * Add python package and training to quickstart * copy edits * Status before big reorganization * Restructure * Write predict tutorial * Other updates for restructuring * YAML configs page * Update homepage index * Save path for CSV * Update tutorials * Update default video loading configs * Record of extra code, then will delete * Remove extra md files * Save path updates * delete more extra files * copy edits * Update args * TODO updates * New default save path * Update megadetector explanation * Better ffmpeg installation instructions * Fix checkpoint saving behavior * Typos * Add troubleshooting sections and format python code blocks better * Add video loading requirements to yaml-config.md * Improve default model descriptions * Begin incorporating feedback * consistent FFmpeg capitalization * index testing * index testing * More feedback * Add debugging page * yaml feedback * Seprate common advanced options page * beautiful magic tabs and more copy editing * Tabs on model page * Support training models with just two classes (#117) * two class metric updates * Update tests/conftest.py Co-authored-by: Emily Miller <[email protected]> Co-authored-by: Emily Miller <[email protected]> * 32 not 31 species (#118) * Add erdantic diagram (#121) * add erdantic diagram * add missing docs reqs * unpin * Write out splits + fix for videos that cannot be loaded (#119) * write out splits * write out zeros for videos that cannot be loaded * create missing save dir * typo * Add OSes and codecov to github actions (#124) * add oses and codecov * try w/o windows * msvc config * test with env var * Give up on Windows for now * [V2] Clean up dev dependencies (#125) * Remove unneeded dev dependencies * Split out docs and lint deps for faster installation Co-authored-by: Jay Qi <[email protected]> * [V2] Release and docs CI (#126) * Add make command to build distributions * Add --version command * Add README * Test built distributions; add failed build notify * Reorder config to keep build metadata together at the top * Rename docs-publish to docs-master * Rename docs-master to docs-latest * Add maintainers docs * Add release workflow * Add mike for versioned docs * Run docs-latest on push to v2 * Remove code tags in nav * Add __main__ for python -m entrypoint Co-authored-by: Jay Qi <[email protected]> * Get default video loader config for models (#127) * get default video loader for model * get default vlc if not specified * set save dir to tmp path so splits.csv is written to temp dir * keep vlc in so we can use for training * add evenly sample * use loguru * set num workers to 3 * remove cpu count * revert change * show ffmpeg error in debug mode * add link to wiki * Rename README.md to MAINTAINING.md (#128) * API Reference with mkdocstrings (#129) * Remove upload_models.py script * Add API Reference with mkdocstrings * Minor documentation tweaks to fix rendering * Use sections instead of auto-expand * Need to install zamba to use mkdocstrings * Put back upload_models.py * Wrap upload_models in if __name__ = '__main__' Co-authored-by: Jay Qi <[email protected]> * Resized test assets (#130) * add resized test assets * resampled to fps=1 * update labels per new videos * update with new video * fix failed test * start python tutorial * Update v2 docs with new changes (#132) * clarify labels filepath columns * start updating video loader config list * update configs * Update video organization reqs * video_width/height and num_workers * filepaths * default num_workers * update num_workers in CLI * writing out train_config and predict_config yamls * splits.csv * updates based on netlify preview * add screencast video demo * fix linting fail * updates for caching PR 131 * typo * use best terminal video from asciinema * specific explanation of frame_selection_height * correct default batch size * add frame_selection_width v model_input_width * talk about num_workers more * flake8 fix * PR feedback * update home page language * fix typo and change from sections to expand * reduce toc depth to 2 to allow expand * use megadetectorlite consistently * move api reference to end * add train data size recs * Update docs/docs/train-tutorial.md rephrase train data size rec Co-authored-by: Emily Miller <[email protected]> * Enable nav index page for models * make contribute section header * Edit MDLite language * put yolox back in Co-authored-by: Emily Miller <[email protected]> Co-authored-by: Jay Qi <[email protected]> * Expose final three models (#133) * add official models dir * remove tf events * move to outside template folder * simplify model mapping; set batch size default to 2 * move official models into zamba * add vlc for slowfast * update manifest for official models * update filename * update filepath * must import models for them to be in available_models * remove config details used for training so these can be the baseline * update config * add backbone finetune config that was used in case defaults change * update labels for time dist; remove slowfast until it is retrained * update per new model * formatting * helper command * already path * Clarify caching (#131) * set ability to turn off caching for prediction * reomve cache dir from cli * test cache dir is set but not used * rename to MODEL_CACHE_DIR for consistency * rename cache_dir to model_cache_dir * move video cache dir into configs * remove unneeded code as caching is off by default * rename to video_cache_dir for clarity * remove * do not support setting in configs * put back in settings * lint and such * rebase fix * put cache_dir and cleanup option on video laoder config * add tests for caching * get empty vlc if none is passed * put within func to avoid writing to real path * add logging * bug fix * reomve old change * loguru uses warning not warn * load dotenv in init * setup logger in init and rename to log_level for simplicity * cleanup does not change hash * fix test * lint * add regression test * do not use load_dotenv * Fix transform look up bug (#135) * separate out weight lookup from class based dict * fix lookup * set split propotions to none if using split in labels * tense * shorten * fix failing test * add updated slowfast model * add test for specifying checkpoint * address deprectation warnings * update templates to reflect final models * fix imports * lint * fix make docs-serve * Update link to models and contribute pages * update erdantic schema * Update references to other pages * Add links to final github source code to docs (#141) * add working links with v2 branch * use master branch instead of v2 * refer to api docs instead of github * Automated workflow for publishing models (#140) * WIP * update weight lookup and hash config to get model name * use auto workflow * auto workflow * add logging * rename to publish models * auto workflow * add code for handling finetuned models * add docs for adding a new model * checklist * update model name * put models in official models dir on s3 * add lookup function * auto workflow * use model dir which is clearer than ckpt * update docs * new slowfast model * rglob needs list * update euro config * only hash once and have function do a lookup * make this not model specific * clarify comments * remove checkpoint from train_config * docs * function to get only model params * use function to subset train config * update yamls based on exclude rather than include * only set checkpoint if not from_scratch, otherwise look up hparams * missing import * lint * checkpoint will now be none for training fromm scratch * remove space * docs-latest needs zamba (#143) * Add densepose model (#142) * Add densepose model * Update densepose install and testing * format * remove errant test yml * more generic codec * append coverage * Update README for v2 (#134) * screencast video demo * video not showing * video show method * autoplay vid * vid * updated terminal video * test video embedding * terminal video * Embed video in README * start updating text * full draft of text * delete vid and update text * editing based on page rendering * rephrase * make same as index.md * update monkey video * edit README * improve formatting * add make docs-setup * delete index.md raw page * hybrid README * update * updates * correct contribute link * add changelog from HISTORY.md * create changelog folder placeholder * delete old changelog md * Simplify caching (#145) * simplify caching * nest function * simplify * move * alphabetize * lint * rename to cache path * fix dataset * Change default backbone finetuning, auto_lr_find, and fix persistent workers bug (#148) * Default patience from 3 to 5 * Default for auto_lr_find to False * Change default unfreeze_backbone_at_epoch to 5 * Fix persistent_workers bug * Revert changes to templates * 496 docs review (#150) * add denspose and update save dir * commit two autogenerated files * changelog edits * contribute edits * WIP edits for models * finish edits for models and separate out densepose * full list of parks * config options * vscode format * move config guide into tutorials * extra options * windows not tested * tutorial edits * remove extra nb * put save path back * quickstart edits * vscode formatting * finish quickstart edits * train tutorial * add template section * logging * ffpmeg install in readme * finetuning * capitalization * remove ffmpmeg * date * add densepose * tweak * simplify * fix densepose video link * caps and tensorboard * add help * remove pythong piece since this is focused on yaml files * more tweaks * edit history not change log * copy edits * fix changelog * table * table * typo * alphabetize * table bug * table edits * Simplify save_dir and some directory -> dir renames (#151) * wip renames * renames in docs * readme * data dir renamme in docs * rename in code from data_directory to data_dir * maintaining update * fix capitalization * further updates * tweak * do not overwrite * add overwrite save dir * add overwrite save dir to config * update configs with all info * use full train configuration * only upload if does not exist * tests for save * overwrite param * better set up and test for overwrite * docs * update docs with overwrite * from overwrite_save_dir to overwrite * missed rename * remove machine specific from vlc * unindent so test actually runs * check for local and cached checkpoints * should be and * write out predict config before preds start like we do for train config * update all configs and use only first 10 digits of hash * dry run check after save is configured; more robust test * reorder * show save directory * copy edits * update template * fix test * lower case for consistency * fix test * Fix docs links (#155) * update readme links * update makefile Co-authored-by: Emily Miller <[email protected]> Co-authored-by: ejm714 <[email protected]> Co-authored-by: Katie Wetstone <[email protected]> Co-authored-by: Jay Qi <[email protected]> Co-authored-by: Jay Qi <[email protected]> Co-authored-by: Katie Wetstone <[email protected]> Co-authored-by: Robert Gibboni <[email protected]>
pjbull
pushed a commit
that referenced
this pull request
Oct 30, 2021
* delete v1 * remove hidden files * Zamba v1 docs port (#108) * workflow tests * remove tests workflow from v2 * Great migration (#113) * copy everything * first round of deletion * more deletions * more deletions * put everything under zamba * remove old readme * replace zamba_algorithms with zamba * integrate makefile * changed files * updates from save dir overwrite * add gitignore * use gitignore from zamba algo * remove load metadata * remove old dirs * lint * remove load metadata * remove load_metadata test * fix datamodule tests * simplify time dist model since there is only one * flake8 * remove unused file * put back lost code * back to long name because that is was model is registered as * species is no longer on model * use models without species prefix and zamba backbone finetune params; * rename time dist head since there is only one * further remove species * use lstrip instead * passing tests * add missing underscore * update links to setup.cfg * specify branches in workflow * update setup.cfg * Update setup.cfg Co-authored-by: Peter Bull <[email protected]> * Update setup.cfg Co-authored-by: Peter Bull <[email protected]> Co-authored-by: Peter Bull <[email protected]> * bug fix (#114) * Skip on failure, actually drop duplicates, clarify logging (#115) * skip on failure, actually drop duplicates, clarify logging * correct comment * only apply to root validators * First draft of zamba v2 docs (#112) * Update zamba predict in cli doc * Update zamba train in cli doc * Formatting * Start updating index * Update ungulate pic * update to chimp image * specify image sizes * update image sizes * add labels to images * Format * add labels to frames * note about top div * start updating inputs_outputs * tweaks to index * Use new vids in index * use full size images * remove some todo notes * comments to cli md * comments to cli md * comments to cli md * Add comments to index * Comments to inputs_outputs * Incorporate preliminary comments * Start working on install * Start working on algorithms * Start reorganizing * Redo quickstart to have a python section * Add basics of slowfast * Use better compressed images * Try and view with new TOC * Add more model info * Start configuration documentation * Add all configurations * Update TOC with configurations doc page * Add where output is saved * Add placeholders for user tutorials * v2 updates * Add info about yolox * Send us labeled videos * Make available models top level * TODO about model details * Better explanation of YAML v CLI args * Copy edits and formatting * Update install page * Add basic use to available models * Update mkdocs.yml * Start working on python package page * Make TOC work correctly * Add explanation of more of the parameter options * Start user tutorials * Update based on new default help text * Copy editing * Add where to reference for python package * Remove repetitive parameter explanation from cli.md * Update TOC names * Update tutorial names * Add python package and training to quickstart * copy edits * Status before big reorganization * Restructure * Write predict tutorial * Other updates for restructuring * YAML configs page * Update homepage index * Save path for CSV * Update tutorials * Update default video loading configs * Record of extra code, then will delete * Remove extra md files * Save path updates * delete more extra files * copy edits * Update args * TODO updates * New default save path * Update megadetector explanation * Better ffmpeg installation instructions * Fix checkpoint saving behavior * Typos * Add troubleshooting sections and format python code blocks better * Add video loading requirements to yaml-config.md * Improve default model descriptions * Begin incorporating feedback * consistent FFmpeg capitalization * index testing * index testing * More feedback * Add debugging page * yaml feedback * Seprate common advanced options page * beautiful magic tabs and more copy editing * Tabs on model page * Support training models with just two classes (#117) * two class metric updates * Update tests/conftest.py Co-authored-by: Emily Miller <[email protected]> Co-authored-by: Emily Miller <[email protected]> * 32 not 31 species (#118) * Add erdantic diagram (#121) * add erdantic diagram * add missing docs reqs * unpin * Write out splits + fix for videos that cannot be loaded (#119) * write out splits * write out zeros for videos that cannot be loaded * create missing save dir * typo * Add OSes and codecov to github actions (#124) * add oses and codecov * try w/o windows * msvc config * test with env var * Give up on Windows for now * [V2] Clean up dev dependencies (#125) * Remove unneeded dev dependencies * Split out docs and lint deps for faster installation Co-authored-by: Jay Qi <[email protected]> * [V2] Release and docs CI (#126) * Add make command to build distributions * Add --version command * Add README * Test built distributions; add failed build notify * Reorder config to keep build metadata together at the top * Rename docs-publish to docs-master * Rename docs-master to docs-latest * Add maintainers docs * Add release workflow * Add mike for versioned docs * Run docs-latest on push to v2 * Remove code tags in nav * Add __main__ for python -m entrypoint Co-authored-by: Jay Qi <[email protected]> * Get default video loader config for models (#127) * get default video loader for model * get default vlc if not specified * set save dir to tmp path so splits.csv is written to temp dir * keep vlc in so we can use for training * add evenly sample * use loguru * set num workers to 3 * remove cpu count * revert change * show ffmpeg error in debug mode * add link to wiki * Rename README.md to MAINTAINING.md (#128) * API Reference with mkdocstrings (#129) * Remove upload_models.py script * Add API Reference with mkdocstrings * Minor documentation tweaks to fix rendering * Use sections instead of auto-expand * Need to install zamba to use mkdocstrings * Put back upload_models.py * Wrap upload_models in if __name__ = '__main__' Co-authored-by: Jay Qi <[email protected]> * Resized test assets (#130) * add resized test assets * resampled to fps=1 * update labels per new videos * update with new video * fix failed test * start python tutorial * Update v2 docs with new changes (#132) * clarify labels filepath columns * start updating video loader config list * update configs * Update video organization reqs * video_width/height and num_workers * filepaths * default num_workers * update num_workers in CLI * writing out train_config and predict_config yamls * splits.csv * updates based on netlify preview * add screencast video demo * fix linting fail * updates for caching PR 131 * typo * use best terminal video from asciinema * specific explanation of frame_selection_height * correct default batch size * add frame_selection_width v model_input_width * talk about num_workers more * flake8 fix * PR feedback * update home page language * fix typo and change from sections to expand * reduce toc depth to 2 to allow expand * use megadetectorlite consistently * move api reference to end * add train data size recs * Update docs/docs/train-tutorial.md rephrase train data size rec Co-authored-by: Emily Miller <[email protected]> * Enable nav index page for models * make contribute section header * Edit MDLite language * put yolox back in Co-authored-by: Emily Miller <[email protected]> Co-authored-by: Jay Qi <[email protected]> * Expose final three models (#133) * add official models dir * remove tf events * move to outside template folder * simplify model mapping; set batch size default to 2 * move official models into zamba * add vlc for slowfast * update manifest for official models * update filename * update filepath * must import models for them to be in available_models * remove config details used for training so these can be the baseline * update config * add backbone finetune config that was used in case defaults change * update labels for time dist; remove slowfast until it is retrained * update per new model * formatting * helper command * already path * Clarify caching (#131) * set ability to turn off caching for prediction * reomve cache dir from cli * test cache dir is set but not used * rename to MODEL_CACHE_DIR for consistency * rename cache_dir to model_cache_dir * move video cache dir into configs * remove unneeded code as caching is off by default * rename to video_cache_dir for clarity * remove * do not support setting in configs * put back in settings * lint and such * rebase fix * put cache_dir and cleanup option on video laoder config * add tests for caching * get empty vlc if none is passed * put within func to avoid writing to real path * add logging * bug fix * reomve old change * loguru uses warning not warn * load dotenv in init * setup logger in init and rename to log_level for simplicity * cleanup does not change hash * fix test * lint * add regression test * do not use load_dotenv * Fix transform look up bug (#135) * separate out weight lookup from class based dict * fix lookup * set split propotions to none if using split in labels * tense * shorten * fix failing test * add updated slowfast model * add test for specifying checkpoint * address deprectation warnings * update templates to reflect final models * fix imports * lint * fix make docs-serve * Update link to models and contribute pages * update erdantic schema * Update references to other pages * Add links to final github source code to docs (#141) * add working links with v2 branch * use master branch instead of v2 * refer to api docs instead of github * Automated workflow for publishing models (#140) * WIP * update weight lookup and hash config to get model name * use auto workflow * auto workflow * add logging * rename to publish models * auto workflow * add code for handling finetuned models * add docs for adding a new model * checklist * update model name * put models in official models dir on s3 * add lookup function * auto workflow * use model dir which is clearer than ckpt * update docs * new slowfast model * rglob needs list * update euro config * only hash once and have function do a lookup * make this not model specific * clarify comments * remove checkpoint from train_config * docs * function to get only model params * use function to subset train config * update yamls based on exclude rather than include * only set checkpoint if not from_scratch, otherwise look up hparams * missing import * lint * checkpoint will now be none for training fromm scratch * remove space * docs-latest needs zamba (#143) * Add densepose model (#142) * Add densepose model * Update densepose install and testing * format * remove errant test yml * more generic codec * append coverage * Update README for v2 (#134) * screencast video demo * video not showing * video show method * autoplay vid * vid * updated terminal video * test video embedding * terminal video * Embed video in README * start updating text * full draft of text * delete vid and update text * editing based on page rendering * rephrase * make same as index.md * update monkey video * edit README * improve formatting * add make docs-setup * delete index.md raw page * hybrid README * update * updates * correct contribute link * add changelog from HISTORY.md * create changelog folder placeholder * delete old changelog md * Simplify caching (#145) * simplify caching * nest function * simplify * move * alphabetize * lint * rename to cache path * fix dataset * Change default backbone finetuning, auto_lr_find, and fix persistent workers bug (#148) * Default patience from 3 to 5 * Default for auto_lr_find to False * Change default unfreeze_backbone_at_epoch to 5 * Fix persistent_workers bug * Revert changes to templates * 496 docs review (#150) * add denspose and update save dir * commit two autogenerated files * changelog edits * contribute edits * WIP edits for models * finish edits for models and separate out densepose * full list of parks * config options * vscode format * move config guide into tutorials * extra options * windows not tested * tutorial edits * remove extra nb * put save path back * quickstart edits * vscode formatting * finish quickstart edits * train tutorial * add template section * logging * ffpmeg install in readme * finetuning * capitalization * remove ffmpmeg * date * add densepose * tweak * simplify * fix densepose video link * caps and tensorboard * add help * remove pythong piece since this is focused on yaml files * more tweaks * edit history not change log * copy edits * fix changelog * table * table * typo * alphabetize * table bug * table edits * Simplify save_dir and some directory -> dir renames (#151) * wip renames * renames in docs * readme * data dir renamme in docs * rename in code from data_directory to data_dir * maintaining update * fix capitalization * further updates * tweak * do not overwrite * add overwrite save dir * add overwrite save dir to config * update configs with all info * use full train configuration * only upload if does not exist * tests for save * overwrite param * better set up and test for overwrite * docs * update docs with overwrite * from overwrite_save_dir to overwrite * missed rename * remove machine specific from vlc * unindent so test actually runs * check for local and cached checkpoints * should be and * write out predict config before preds start like we do for train config * update all configs and use only first 10 digits of hash * dry run check after save is configured; more robust test * reorder * show save directory * copy edits * update template * fix test * lower case for consistency * fix test * Fix docs links (#155) * update readme links * update makefile Co-authored-by: Emily Miller <[email protected]> Co-authored-by: ejm714 <[email protected]> Co-authored-by: Katie Wetstone <[email protected]> Co-authored-by: Jay Qi <[email protected]> Co-authored-by: Jay Qi <[email protected]> Co-authored-by: Katie Wetstone <[email protected]> Co-authored-by: Robert Gibboni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All models now use
save_dir-- previously this was only used by TrainConfig. PredictConfig let you use asave_pathfor predictions but that doesn't make sense anymore now that we write out the predict config yaml in addition to the csv. DensePose used to usesave_pathbut used it as a directory. Now everybody is doing the same thing.Config changes:
saveandsave_dir(instead ofsave_path) -- this supports a cli--no-saveif desiredoverwriteas well which lets you overwrite the zamba_predictions.csv and predict_configuration.yaml in the save directory.overwriteinstead ofoverwrite_save_dirso this is consistent with PredictConfigsave_dirinstead ofsave_pathRenames:
Using
dirthroughout is consistent with our cache dirs and CLI arguments.Bonus fix:
train_configuration.yamlinstead ofconfig.yamlas base for official model config. this ensures that if defaults change and we re-publish models, the configs don't change. i also updated the train_configuration yamls to align with the config updates so they're good examples for users. this will inherently change the public checkpoint hashes (files have been updated on s3)