Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use variable for client schemes, allowing override #467

Merged

use variable for client schemes, allowing override

54c37b2
Select commit
Loading
Failed to load commit list.
Merged

use variable for client schemes, allowing override #467

use variable for client schemes, allowing override
54c37b2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 31, 2024 in 1s

93.3% (-1.0%) compared to b776bee

View this Pull Request on Codecov

93.3% (-1.0%) compared to b776bee

Details

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.3%. Comparing base (b776bee) to head (54c37b2).

Files with missing lines Patch % Lines
cloudpathlib/azure/azblobclient.py 80.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #467     +/-   ##
========================================
- Coverage    94.2%   93.3%   -1.0%     
========================================
  Files          23      23             
  Lines        1745    1752      +7     
========================================
- Hits         1645    1635     -10     
- Misses        100     117     +17     
Files with missing lines Coverage Δ
cloudpathlib/client.py 88.2% <100.0%> (+0.1%) ⬆️
cloudpathlib/gs/gsclient.py 90.1% <100.0%> (-1.4%) ⬇️
cloudpathlib/local/implementations/azure.py 97.6% <100.0%> (+<0.1%) ⬆️
cloudpathlib/local/implementations/gs.py 100.0% <100.0%> (ø)
cloudpathlib/local/implementations/s3.py 100.0% <100.0%> (ø)
cloudpathlib/s3/s3client.py 93.0% <100.0%> (-1.4%) ⬇️
cloudpathlib/azure/azblobclient.py 90.0% <80.0%> (-6.9%) ⬇️