Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test infra improvements #461

Merged
merged 14 commits into from
Aug 29, 2024
Merged

Test infra improvements #461

merged 14 commits into from
Aug 29, 2024

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented Aug 15, 2024

I'll say this is "ready" once I get 5 error-free passes.


A few improvements:

  • Add test timing reporting information for simple perf comparisons and debugging.
  • Unpin pytest/pytest-cases since new ones are compatible
  • Update waiting strategy for flakiest tests

Copy link
Contributor

github-actions bot commented Aug 15, 2024

@github-actions github-actions bot temporarily deployed to pull request August 15, 2024 00:22 Inactive
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (5656879) to head (6f51524).
Report is 3 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #461   +/-   ##
======================================
  Coverage    94.2%   94.2%           
======================================
  Files          23      23           
  Lines        1728    1728           
======================================
  Hits         1629    1629           
  Misses         99      99           

@github-actions github-actions bot temporarily deployed to pull request August 15, 2024 05:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 15, 2024 05:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 15, 2024 05:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 20, 2024 23:48 Inactive
@pjbull pjbull mentioned this pull request Aug 20, 2024
4 tasks
@pjbull pjbull changed the title Test infra improvements WIP: Test infra improvements Aug 20, 2024
@github-actions github-actions bot temporarily deployed to pull request August 20, 2024 23:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 14:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 15:17 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 16:28 Inactive
@pjbull
Copy link
Member Author

pjbull commented Aug 22, 2024

@jayqi Ready, but not urgent. Thinking this can be just post-release since it is not really user-facing. I hope it improves test reliability, but in my experience failures seem to be related in some way to resource load on shared GH runners (failures seem to cluster in time). It just needs a history change added, but didn't want to collide with #463

@pjbull pjbull changed the title WIP: Test infra improvements Test infra improvements Aug 23, 2024
@github-actions github-actions bot temporarily deployed to pull request August 28, 2024 23:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 29, 2024 01:33 Inactive
@pjbull pjbull merged commit b776bee into master Aug 29, 2024
25 checks passed
@pjbull pjbull deleted the test-infra-improvements branch August 29, 2024 18:25
@pjbull pjbull mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant