Update write_text to include newline variable #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pricemg
commented
Aug 31, 2023
pricemg
commented
Sep 1, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
========================================
- Coverage 93.9% 93.5% -0.4%
========================================
Files 22 22
Lines 1512 1512
========================================
- Hits 1420 1414 -6
- Misses 92 98 +6
|
|
Looks good to me, thanks @pricemg! Could you also add a note to |
|
Thanks @pjbull done that now, thought i had more things to look into for those failing CICD checks so happy to hand it over :D |
|
Merging for live test run |
pjbull
added a commit
that referenced
this pull request
Sep 14, 2023
* Update write_text to include newline variable * Remove old docstring link * Update cloudpathlib/cloudpath.py with black correction * Remove use of io module * update HISTORY.md Co-authored-by: Matthew Price <[email protected]>
|
Thanks @pricemg, this has now shipped in version |
msmitherdc
added a commit
to CRREL/cloudpathlib
that referenced
this pull request
Nov 1, 2023
* Add "CloudPath" to possible cloud_path types (drivendataorg#342) (drivendataorg#343) * Add "CloudPath" to possible cloud_path types (drivendataorg#342) * Add to changelog --------- Co-authored-by: Karol Zlot <[email protected]> * Added with_stem support (drivendataorg#290) (drivendataorg#354) * Added with_stem support * Update readme (+small fix to make_support_table) * Added test * Update history.md * Fallback to trivial CPython implementation if `with_stem` is not available * Add a clarification comment Co-authored-by: Daniel Oriyan <[email protected]> * Fix flake8 errors (drivendataorg#359) * Fix flake8 errors * Fix wrong comparison * Bump codecov action version; add codecov token --------- Co-authored-by: Jay Qi <[email protected]> * Update write_text to include newline variable (drivendataorg#362) (drivendataorg#363) * Update write_text to include newline variable * Remove old docstring link * Update cloudpathlib/cloudpath.py with black correction * Remove use of io module * update HISTORY.md Co-authored-by: Matthew Price <[email protected]> * Add support for Python 3.12 (drivendataorg#364) * passing tests * remove print * make method signatures match * Remove unused import * ignore type errors * ignore more type errors * make linting and tests work on multiple py versions * add 3.12 to CI and pyproject * use pytest-cases fork * More performant walk implementation * format * update methods * Test walk method * Version agnostic tests * update tests * Add tests * Order agnostic walk test * Changes * Update changelog * sleep for flaky test * Sleep flaky tests * sleepier * implement env var for local cache dir (drivendataorg#361) * Add contributing guidelines (drivendataorg#367) * contributing guidelines * Apply suggestions from code review Co-authored-by: Katie Wetstone <[email protected]> * WIP * Contrib tweaks and PR template * clarification * update history typo --------- Co-authored-by: Katie Wetstone <[email protected]> * Version bump * format with black * ignore type checking here * update client reference * update * no need to change --------- Co-authored-by: Peter Bull <[email protected]> Co-authored-by: Karol Zlot <[email protected]> Co-authored-by: Daniel Oriyan <[email protected]> Co-authored-by: Jay Qi <[email protected]> Co-authored-by: Jay Qi <[email protected]> Co-authored-by: Matthew Price <[email protected]> Co-authored-by: Peter Bull <[email protected]> Co-authored-by: Katie Wetstone <[email protected]> Co-authored-by: Michael D. Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of python3.10
write_textin thepathlibmodule also has the optional argumentnewline(code).Adding in the functionality to the
opencall.