Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pydantic compatibility warning #348

Closed
wants to merge 3 commits into from
Closed

pydantic compatibility warning #348

wants to merge 3 commits into from

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented Jul 9, 2023

Actual migration to support 2.0.0 is going to be a bunch more work, so adding just the warning for the time being.

pip list | grep pydantic
pydantic                   1.10.11python
Python 3.11.4 (main, Jul  5 2023, 08:41:25) [Clang 14.0.6 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import cloudpathlib
>>> quit()

❯ pip install -U pydantic
...
Successfully installed pydantic-2.0.2python
Python 3.11.4 (main, Jul  5 2023, 08:41:25) [Clang 14.0.6 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import cloudpathlib
/Users/bull/code/cloudpathlib/cloudpathlib/__init__.py:49: PydanticVersionWarning: This version of cloudpathlib is only compatible with pydantic<2.0.0. You can ignore this warning if none of your pydantic models are annotated with cloudpathlib types.
  warn(PydanticVersionWarning(PydanticVersionWarning.message))

Docs preview:
https://deploy-preview-348--gallant-agnesi-5f7bb3.netlify.app/integrations/
image

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

@github-actions github-actions bot temporarily deployed to pull request July 9, 2023 18:15 Inactive
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #348 (1bfb82c) into master (2a3d712) will decrease coverage by 0.3%.
The diff coverage is 70.0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #348     +/-   ##
========================================
- Coverage    94.2%   93.9%   -0.3%     
========================================
  Files          22      22             
  Lines        1484    1494     +10     
========================================
+ Hits         1399    1404      +5     
- Misses         85      90      +5     
Impacted Files Coverage Δ
cloudpathlib/__init__.py 87.5% <70.0%> (-12.5%) ⬇️

... and 1 file with indirect coverage changes

@github-actions github-actions bot temporarily deployed to pull request July 9, 2023 18:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 9, 2023 18:28 Inactive
@pjbull pjbull requested a review from jayqi July 9, 2023 18:48
@pjbull pjbull mentioned this pull request Jul 10, 2023
@pjbull
Copy link
Member Author

pjbull commented Jul 10, 2023

Actually, not sure that we need this PR if we merge #349. It may be nice to give folks a warning on this version, but since we can do side-by-side, people can simply upgrade to the next release if they need pydantic v2 support.

@pjbull pjbull closed this Jul 10, 2023
@pjbull pjbull deleted the pin-pydantic branch September 4, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant