Fix flake8 errors (#359)

* Fix flake8 errors * Fix wrong comparison * Bump codecov action version; add codecov token --------- Co-authored-by: Jay Qi <[email protected]>
drivendataorg · Jul 31, 2023 · d2079cc · d2079cc
1 parent 45ae4ee
commit d2079cc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -76,8 +76,9 @@ jobs:
 
       - name: Upload coverage to codecov
         if: matrix.os == 'ubuntu-latest'
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v3
         with:
+          token: ${{ secrets.CODECOV_TOKEN }}
           file: ./coverage.xml
           fail_ci_if_error: true
 

diff --git a/cloudpathlib/cloudpath.py b/cloudpathlib/cloudpath.py
@@ -559,7 +559,7 @@ def _patched_close_empty_cache(*args, **kwargs):
         return buffer
 
     def replace(self, target: Self) -> Self:
-        if type(self) != type(target):
+        if type(self) is not type(target):
             raise TypeError(
                 f"The target based to rename must be an instantiated class of type: {type(self)}"
             )

diff --git a/tests/test_local.py b/tests/test_local.py
@@ -36,7 +36,7 @@ def test_interface(cloud_class, local_class):
         cloud_attr = getattr(cloud_class, attr_name)
         local_attr = getattr(local_class, attr_name)
 
-        assert type(cloud_attr) == type(local_attr)
+        assert type(cloud_attr) is type(local_attr)
         if callable(cloud_attr):
             assert signature(cloud_attr).parameters == signature(local_attr).parameters