refactor: integrate FailoverProvider #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚅 Previously deployed to Railway in the Drips App project. Environment has been deleted. |
efstajas
requested changes
Oct 15, 2024
| } else if (provider === 'alchemy') { | ||
| const alchemyKey = getOptionalEnvVar('ALCHEMY_KEY'); | ||
| assert(alchemyKey, 'ALCHEMY_KEY is required'); | ||
| rpcUrl = `https://${alchemyNetworkMap[network as keyof typeof alchemyNetworkMap]}.g.alchemy.com/v2/${alchemyKey}`; |
There was a problem hiding this comment.
The typecast here could be unsafe if provider is alchemy but network is filecoin-mainnet. Generally I think typecasting should be avoided unless absolutely necessary. I would assert explicitly here that network is included in alchemyNetworkMap
There was a problem hiding this comment.
oh also, i think the entire block would be neater as a switch statement
.env.template
Outdated
Comment on lines
4
to
9
| # Optional Infura key. | ||
| INFURA_KEY=string | ||
| # Optional Alchemy key. | ||
| ALCHEMY_KEY=string | ||
| # Optional Filecoin key. | ||
| FILECOIN_KEY=string |
There was a problem hiding this comment.
could you just add a sentence explaining that values for at least one of the providers are required?
efstajas
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.