explicit errors if gasless owner update fails #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚅 Previously deployed to Railway in the Drips App project. Environment has been deleted. |
jtourkos
approved these changes
Oct 14, 2024
mhgbrown
approved these changes
Oct 14, 2024
| @@ -46,6 +47,38 @@ | |||
| } | |||
| `; | |||
|
|
|||
| assert($context.gaslessOwnerUpdateTaskId, 'Gasless owner update task ID is missing'); | |||
There was a problem hiding this comment.
Does assert eventually produce some sort of global error display for the user?
There was a problem hiding this comment.
Yep, any error thrown within the context of a Stepper will be caught by the stepper component and trigger an Error step that just stringifies the error and shows it to the user. Doesn't matter if that error came from assert or elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the gasless owner update in the project claim flow fails to kick off (e.g. Gelato Relay down) or the task fails to conclude (e.g. we ran out of balance to sponsor gas with), the user is just left sitting on the "Waiting for verification to finalize..." screen while the app polls the API in anticipation of the owner updating. Which of course will never happen in those cases. This adds explicit checks for a successful gasless owner update call, and checks the task state on Gelato for failures. In both cases, the user will see "friendly" errors asking for them to either try again or reach out to us on Discord.