-
Notifications
You must be signed in to change notification settings - Fork 140
program: add admin_deposit #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
youll wanna add anchor test or do test on devnet to make sure works correctly
total_withdraws_after, | ||
market_index, | ||
explanation: DepositExplanation::Reward, | ||
transfer_user: Some(ctx.accounts.admin.key()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might wanna check if this will confuse ui?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can make this None, since explanation is already Reward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless we want to avoid creating a new Reward
enum and do something confusing like transfer_user == admin
to signify a reward.
No description provided.