Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.2.0 #75

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Release/1.2.0 #75

merged 2 commits into from
Feb 8, 2025

Conversation

driessamyn
Copy link
Owner

No description provided.

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Consolidate redundant Git status checks

The Git status checks are redundant and should be consolidated into a single
step to improve workflow efficiency and readability.

.github/workflows/gh-publish.yml [33-36]

-- name: Git Status
-  run: git status
-- name: Untracked changes
-  run: git ls-files . --exclude-standard --others
+- name: Check Git Status
+  run: |
+    git status
+    git ls-files . --exclude-standard --others
  • Apply this suggestion
Suggestion importance[1-10]: 5

__

Why: Combining the two Git status check steps into one would improve workflow readability and reduce verbosity, though this is a minor optimization that doesn't affect functionality.

Low

Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link

github-actions bot commented Feb 7, 2025

Test Results

 32 files  ±0   32 suites  ±0   29s ⏱️ -3s
209 tests ±0  209 ✅ ±0  0 💤 ±0  0 ❌ ±0 
267 runs  ±0  267 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e244b83. ± Comparison against base commit 31ee776.

This pull request removes 38 and adds 37 tests. Note that renamed tests count towards both.

net.samyn.kapper.QueryParserTest ‑ [5] 
net.samyn.kapper.SQLTypesConverterTest ‑ [10] LONGNVARCHAR, LONGNVARCHAR, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$628/0x00007fb9083f5be8@6d4ed8bc
net.samyn.kapper.SQLTypesConverterTest ‑ [11] INSTANT, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$808/0x00007fb9084ea9b0@56358554
net.samyn.kapper.SQLTypesConverterTest ‑ [11] LONGVARCHAR, LONGVARCHAR, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$629/0x00007fb9083f5e10@1815a2e5
net.samyn.kapper.SQLTypesConverterTest ‑ [12] DATE, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$809/0x00007fb9084eabd8@8da37a0
net.samyn.kapper.SQLTypesConverterTest ‑ [12] NCHAR, NCHAR, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$630/0x00007fb9083f6038@5f005e21
net.samyn.kapper.SQLTypesConverterTest ‑ [13] NCLOB, NCLOB, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$631/0x00007fb9083f6260@70cd674a
net.samyn.kapper.SQLTypesConverterTest ‑ [14] NVARCHAR, NVARCHAR, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$632/0x00007fb9083f6488@6e1b3c38
net.samyn.kapper.SQLTypesConverterTest ‑ [15] ROWID, ROWID, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$633/0x00007fb9083f66b0@67239f32
…
net.samyn.kapper.QueryParserTest ‑ [5] 

net.samyn.kapper.SQLTypesConverterTest ‑ [10] LONGNVARCHAR, LONGNVARCHAR, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$637/0x00007fd5943fa040@604bff84
net.samyn.kapper.SQLTypesConverterTest ‑ [11] INSTANT, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$813/0x00007fd5944ea3c0@ac1a3bb
net.samyn.kapper.SQLTypesConverterTest ‑ [11] LONGVARCHAR, LONGVARCHAR, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$638/0x00007fd5943fa268@3bb95bb9
net.samyn.kapper.SQLTypesConverterTest ‑ [12] DATE, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$814/0x00007fd5944ea5e8@324a2358
net.samyn.kapper.SQLTypesConverterTest ‑ [12] NCHAR, NCHAR, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$639/0x00007fd5943fa490@67a7ded5
net.samyn.kapper.SQLTypesConverterTest ‑ [13] NCLOB, NCLOB, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$640/0x00007fd5943fa900@dd31bb5
net.samyn.kapper.SQLTypesConverterTest ‑ [14] NVARCHAR, NVARCHAR, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$641/0x00007fd5943fab28@71bd9e54
net.samyn.kapper.SQLTypesConverterTest ‑ [15] ROWID, ROWID, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$642/0x00007fd5943fad50@2f33afec
net.samyn.kapper.SQLTypesConverterTest ‑ [16] SQLXML, SQLXML, net.samyn.kapper.SQLTypesConverterTest$Companion$$Lambda$643/0x00007fd5943faf78@37362869
…

Copy link

github-actions bot commented Feb 7, 2025

Code Coverage

Total Project Coverage 100.00%

@driessamyn driessamyn merged commit 1998123 into main Feb 8, 2025
5 of 7 checks passed
@driessamyn driessamyn deleted the release/1.2.0 branch February 8, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant