Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#209] Supported additional entity properties when creating files. #210

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

ericgsmith
Copy link
Contributor

@ericgsmith ericgsmith commented Apr 2, 2024

#209

Checklist before requesting a review

  • I have formatted the subject to include ticket number
    as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was
    done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and
    they passed
  • I have provided screenshots, where applicable

Changed

  1. Added additional test check for entity exists by UUID to verify that the additionally provided field is used

Screenshots

@ericgsmith ericgsmith marked this pull request as ready for review April 2, 2024 01:38
@AlexSkrypnyk
Copy link
Member

@ericgsmith
This is excellent! thank you for your contribution.

@AlexSkrypnyk AlexSkrypnyk merged commit 158630c into drevops:main Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants