Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid double-including src when excludeAppGlideModule = true #124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid double-including src when excludeAppGlideModule = true #124

wants to merge 1 commit into from

Conversation

kibiz0r
Copy link

@kibiz0r kibiz0r commented Nov 11, 2024

Looks like #37 accidentally broke excludeAppGlideModule

@github-actions GitHub Actions
Copy link

🚀 Thanks for your first Pull Request!
Your contribution is greatly appreciated, and a maintainer will review it soon.
Meanwhile, feel free to check out other issues or share your thoughts on the project.
We’re excited to have you on board! 🎉

@princektripathi
Copy link
Contributor

Looks like #37 accidentally broke excludeAppGlideModule

@kibiz0r, thanks for raising the PR. Can you please share a repro to validate ?

@princektripathi princektripathi added the Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarthak-d11 sarthak-d11 Awaiting requested review from sarthak-d11

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
First PR Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kibiz0r @princektripathi