Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cell): fix cell format of rich text #4261

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Conversation

wpxp123456
Copy link
Contributor

close https://github.com/dream-num/univer-pro/issues/3689

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 9, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 46 seconds
commit  868104b
info  For more information, see full report

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.35%. Comparing base (a0838c5) to head (868104b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...rc/controllers/editor/editing.render-controller.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4261      +/-   ##
==========================================
+ Coverage   33.33%   33.35%   +0.01%     
==========================================
  Files        2521     2521              
  Lines      129924   129929       +5     
  Branches    29019    29021       +2     
==========================================
+ Hits        43313    43338      +25     
+ Misses      86611    86591      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo
Copy link

2024_12_25 10_40_14 video.webm
无法对整个数字文本内容设置字体颜色

@univer-bot
Copy link

univer-bot bot commented Dec 25, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

2024_12_25 10_40_14 video.webm
Unable to set font color for entire numeric text content

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels Dec 25, 2024
@wpxp123456 wpxp123456 force-pushed the fix/cell-text-format-richtext branch from e454c7c to 6bc8512 Compare December 25, 2024 07:25
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 25, 2024
@univer-bot univer-bot bot removed the qa:rejected label Dec 25, 2024
@wpxp123456 wpxp123456 merged commit 91c201a into dev Dec 25, 2024
9 checks passed
@wpxp123456 wpxp123456 deleted the fix/cell-text-format-richtext branch December 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants