Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush stdout everywhere on Travis to avoid out-of-order output #323

Closed
wants to merge 2 commits into from

Conversation

asmeurer
Copy link
Member

@asmeurer asmeurer commented Sep 5, 2018

#322

I haven't fixed it yet. I'm using this branch to debug it.

This should help with out-of-order command output.
@asmeurer
Copy link
Member Author

asmeurer commented Sep 5, 2018

I tried to reproduce it on my fork and I couldn't asmeurer/xonsh#1

@asmeurer
Copy link
Member Author

asmeurer commented Sep 5, 2018

OK, my PR build at https://travis-ci.org/asmeurer/xonsh/jobs/424980715 literally merges the exact same two commits together as the failing build from the issue, and it doesn't reproduce the issue.

@asmeurer
Copy link
Member Author

asmeurer commented Sep 5, 2018

Maybe I need to have doctr enabled or else it won't run.

This should take care of all out-of-order output issues.
@asmeurer asmeurer mentioned this pull request Sep 5, 2018
@asmeurer
Copy link
Member Author

asmeurer commented Sep 5, 2018

Turns out this was an issue with the xonsh .travis.yml. However, I like having flushing to keep the output in order. You can see from the failing build that for instance "The website and docs are not pushed to gh-pages on pull requests" is printed at the end after the git stash pop, when it should be printed from this function. So I'm going to merge this PR anyway.

@asmeurer asmeurer changed the title Attempts at fixing the git stash issue Flush stdout everywhere on Travis to avoid out-of-order output Sep 5, 2018
@asmeurer
Copy link
Member Author

asmeurer commented Sep 5, 2018

Oh it still happens. I guess it has to do with the way Travis mixes stdout and stderr.

@asmeurer
Copy link
Member Author

I don't think this will help. The problem is that Travis doesn't output stderr alongside stdout like you would get in a terminal, even with flushing. Probably we should avoid using stderr on Travis, since it doesn't do anything anyway (but other things like tracebacks being out of order can't be helped).

@asmeurer asmeurer closed this Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant