Allow setting verify_hostname to false #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanmb
commented
Sep 9, 2024
| @@ -1111,7 +1111,7 @@ def verify_mode= verify_mode | |||
| end | |||
|
|
|||
| ## | |||
| # Sets the HTTPS verify_hostname. Defaults to false. | |||
| # Sets the HTTPS verify_hostname. | |||
There was a problem hiding this comment.
As per #120
net/http/persistent should be thin wrapper,
This setting actually comes from SSLContext's default and it defaults to true. The old comment is at best misleading.
See also ruby/ruby#2858.
stefanmb
commented
Sep 9, 2024
| @@ -1001,7 +1001,7 @@ def ssl connection | |||
| connection.verify_depth = @verify_depth | |||
| connection.verify_mode = @verify_mode | |||
| connection.verify_hostname = @verify_hostname if | |||
| @verify_hostname && connection.respond_to?(:verify_hostname=) | |||
| @verify_hostname != nil && connection.respond_to?(:verify_hostname=) | |||
There was a problem hiding this comment.
nil means we don't set this option and want the default from net/http, whereas false is an explicit choice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #120.
In that PR
verify_hostnamewas added, but it cannot be set tofalsewhich its main function as a configurable option as per ruby/ruby#2858.