forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][broker] PIP-264: Add transaction metrics #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragosvictor
force-pushed
the
dmisca-pip-264-transaction-metrics
branch
from
June 21, 2024 19:47
969d1ff
to
3e73bf0
Compare
dragosvictor
force-pushed
the
dmisca-pip-264-transaction-metrics
branch
from
June 22, 2024 22:26
a6b326b
to
8966ee8
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP-264
Motivation
Adds the transaction metrics as described by https://pulsar.apache.org/docs/next/reference-metrics/#pulsar-transaction to the OpenTelemetry pipeline.
Modifications
pulsar.broker.topic
metric prefix, as they relate closely to the topic metrics. ClassPersistentTopicAttributes
is updated to reflect this change.Verifying this change
This change updated tests and can be verified as follows:
TransactionTest#testTopicTransactionMetrics
TopicTransactionBufferTest#testTransactionBufferAppendMarkerWriteFailState
PendingAckPersistentTest#testPendingAckMetrics
Does this pull request potentially affect one of the following parts:
Documentation
doc
doc-required
[feat][doc] PIP-264: Add transaction metrics reference apache/pulsar-site#925doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: #37