Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][broker] PIP-264: Add transaction metrics #37

Closed
wants to merge 18 commits into from

Conversation

dragosvictor
Copy link
Owner

@dragosvictor dragosvictor commented Jun 21, 2024

PIP-264

Motivation

Adds the transaction metrics as described by https://pulsar.apache.org/docs/next/reference-metrics/#pulsar-transaction to the OpenTelemetry pipeline.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

This change updated tests and can be verified as follows:

  • Updated test TransactionTest#testTopicTransactionMetrics
  • Updated test TopicTransactionBufferTest#testTransactionBufferAppendMarkerWriteFailState
  • Updated test PendingAckPersistentTest#testPendingAckMetrics

Does this pull request potentially affect one of the following parts:

Documentation

Matching PR in forked repository

PR in forked repository: #37

@dragosvictor dragosvictor force-pushed the dmisca-pip-264-transaction-metrics branch from 969d1ff to 3e73bf0 Compare June 21, 2024 19:47
@dragosvictor dragosvictor force-pushed the dmisca-pip-264-transaction-metrics branch from a6b326b to 8966ee8 Compare June 22, 2024 22:26
@dragosvictor dragosvictor marked this pull request as ready for review June 25, 2024 18:53
@dragosvictor dragosvictor deleted the dmisca-pip-264-transaction-metrics branch June 27, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant