Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] 18309: fix of jdk-8180450 #892

Merged
merged 6 commits into from
Dec 17, 2024
Merged

[Backport] 18309: fix of jdk-8180450 #892

merged 6 commits into from
Dec 17, 2024

Conversation

ziyilin
Copy link
Collaborator

@ziyilin ziyilin commented Nov 25, 2024

The type pollution issue of JDK causes significant performance slowing down when type is checked concurrently.
The upstream has fixed this issue for JDK 24 and 22. This PR backports the fix to JDK11.

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ziyilin ziyilin changed the title Backport fix of jdk-8180450 [Backport] 18309: fix of jdk-8180450 Nov 26, 2024
@ziyilin ziyilin force-pushed the backport-8180450 branch 4 times, most recently from 0a7c8d6 to 71bac6a Compare December 5, 2024 08:34
@ziyilin
[Backport] 18309: Backport fix of jdk-8180450
89628ae 
Summary:Backport the fix of issue JDK-8180450 to dragonwell 11
Testing: JTreg
Reviewers: Kuaiwei, wenjie
Issue: https://github.com/dragonwell-project/dragonwell11/issues/893a
kuaiwei
kuaiwei approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@kuaiwei kuaiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoshuaZhuwj
Copy link
Collaborator

There are also several JDK bugs related to JDK-8180450.
Please check them at: https://bugs.openjdk.org/browse/JDK-8180450.

@ziyilin
Copy link
Collaborator Author

ziyilin commented Dec 16, 2024 •
edited
Loading

Backported:
https://bugs.openjdk.org/browse/JDK-8334220
https://bugs.openjdk.org/browse/JDK-8332228
https://bugs.openjdk.org/browse/JDK-8331159
https://bugs.openjdk.org/browse/JDK-8332498

Won't backport others for RISC-V, PPC64 and the improving patch for C1 and interpreter.

@ziyilin
[Backport] : 8332498: [aarch64, x86] improving OpToAssembly output for
77bdab9 
Summary: 8332498: [aarch64, x86] improving OpToAssembly output for
partialSubtypeCheckConstSuper Instruct
Testing: jtreg
Issue: https://bugs.openjdk.org/browse/JDK-8332498
@JoshuaZhuwj
Copy link
Collaborator

I saw the same build error message for win-x64 platform:
"assembler_x86.cpp
d:\a\dragonwell11\dragonwell11\src\hotspot\cpu\x86\assembler_x86.cpp(10639): error C2220: the following warning is treated as an error
d:\a\dragonwell11\dragonwell11\src\hotspot\cpu\x86\assembler_x86.cpp(10639): warning C4309: 'argument': truncation of constant value"

It seems related to this commit.

@ziyilin
Copy link
Collaborator Author

ziyilin commented Dec 17, 2024

Should backport this fix https://bugs.openjdk.org/browse/JDK-8295414, too

@JoshuaZhuwj JoshuaZhuwj self-requested a review December 17, 2024 09:35
JoshuaZhuwj
JoshuaZhuwj approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@JoshuaZhuwj JoshuaZhuwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
It would be better to do full jtreg test on all our available platforms.

@sendaoYan sendaoYan merged commit b985104 into dragonwell-project:master Dec 17, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaZhuwj JoshuaZhuwj JoshuaZhuwj approved these changes

@kuaiwei kuaiwei kuaiwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ziyilin @CLAassistant @JoshuaZhuwj @kuaiwei @sendaoYan