Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Fix testcase that depend on docker build #873

Merged

Conversation

lingjun-cg
Copy link
Collaborator

Summary: A previous CRaC pactch change the signature of DockerTestUtils.buildJdkContainerImage(String imageName).All testcases depend on docker build will compile failed.

Testing: TestMemoryWithCgroupV1.java

Reviewed-by: yansendao.ysd,lvfei.lv

Issue: #872

Summary: A previous CRaC pactch change the signature of DockerTestUtils.buildJdkContainerImage(String imageName).All testcases depend on docker build will compile failed.

Testing: TestMemoryWithCgroupV1.java

Reviewers: yansendao.ysd,lvfei.lv

Issue: dragonwell-project#872
Copy link
Collaborator

@sendaoYan sendaoYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Collaborator

@Accelerator1996 Accelerator1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Accelerator1996 Accelerator1996 merged commit 85a2ef0 into dragonwell-project:master Oct 21, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants