Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: test build with more architectures #1510

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Dec 8, 2023

Relevant Issue (if applicable)

https://github.com/dragonflyoss/nydus/actions/workflows/release.yml?query=event%3Aschedule

Details

To prevent build errors in different architectures, we should test build with more architectures in Smoke Test, but only use amd64 in the next jobs.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested a review from a team as a code owner December 8, 2023 11:10
@Desiki-high Desiki-high requested review from liubin, imeoer and changweige and removed request for a team December 8, 2023 11:10
@Desiki-high Desiki-high force-pushed the smoke-test/mutil-plt-build branch 3 times, most recently from f12ddf9 to d3c9353 Compare December 9, 2023 06:20
@Desiki-high Desiki-high requested a review from a team as a code owner December 9, 2023 06:20
@Desiki-high Desiki-high requested review from ccx1024cc and removed request for a team December 9, 2023 06:20
@Desiki-high Desiki-high force-pushed the smoke-test/mutil-plt-build branch 3 times, most recently from 7fa39be to 40f068e Compare December 9, 2023 06:38
@Desiki-high
Copy link
Member Author

It looks like dbs-snapshot don't support riscv64 and ppc64le, So the Release failed.

@imeoer
Copy link
Collaborator

imeoer commented Dec 11, 2023

Thanks for the PR, it seems we need to make dbs-snapshot also work on ppc64le and riscv64: https://github.com/kata-containers/dbs-snapshot/blob/098fca6c819fc3e3be4329e1cf8b09f98450b3be/src/lib.rs#L41, are you interested in submitting a PR for dbs-snapshot? It's a rust crate we maintained.

@Desiki-high
Copy link
Member Author

Thanks for the PR, it seems we need to make dbs-snapshot also work on ppc64le and riscv64: https://github.com/kata-containers/dbs-snapshot/blob/098fca6c819fc3e3be4329e1cf8b09f98450b3be/src/lib.rs#L41, are you interested in submitting a PR for dbs-snapshot? It's a rust crate we maintained.

I can try it later.

@Desiki-high Desiki-high changed the title action: test build with more architectures [WIP]action: test build with more architectures Dec 12, 2023
@Desiki-high
Copy link
Member Author

Try to fix it at kata-containers/dbs-snapshot#5.

Test build with more architectures, but only use `amd64` in next jobs.

Signed-off-by: Yadong Ding <[email protected]>
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #1510 (86030f4) into master (a4ec9b8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
- Coverage   60.89%   60.88%   -0.01%     
==========================================
  Files         141      141              
  Lines       46277    46277              
  Branches    44153    44153              
==========================================
- Hits        28180    28178       -2     
  Misses      16658    16658              
- Partials     1439     1441       +2     

see 1 file with indirect coverage changes

v1.5.1 brings support of ppc64le and riscv64.

Signed-off-by: Yadong Ding <[email protected]>
error: failed to compile `cross v0.2.4`, intermediate artifacts can be found at `/tmp/cargo-installG1Scm4`

Caused by:
  package `home v0.5.9` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.68.2
  Try re-running cargo install with `--locked`

Signed-off-by: Yadong Ding <[email protected]>
@Desiki-high Desiki-high changed the title [WIP]action: test build with more architectures action: test build with more architectures Dec 19, 2023
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imeoer imeoer merged commit 18ba2ed into dragonflyoss:master Dec 19, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants