fix(e2e): add tests for latest features #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pothulapati
force-pushed
the
tar/tests
branch
3 times, most recently
from
21fb8b8 to
03e11ff
Compare
Pothulapati
force-pushed
the
tar/tests
branch
from
b724100 to
ec056c2
Compare
Abhra303
reviewed
Sep 19, 2023
| @@ -96,6 +96,10 @@ func GetDragonflyResources(ctx context.Context, df *resourcesv1.Dragonfly) ([]cl | |||
| Name: DragonflyPortName, | |||
| ContainerPort: DragonflyPort, | |||
| }, | |||
| { | |||
| Name: "admin", | |||
There was a problem hiding this comment.
This wasn't the issue actually i.e https://stackoverflow.com/questions/63526825/kubernetes-service-without-defined-port#:~:text=Yes%20you%20can%20expose%20service,uses%2C%20but%20is%20primarily%20informational.
But the issue was to have admin_nopass otherwise when password is set, we get a bunch of noauth errors. This is required.
diffuse
pushed a commit
to diffuse/dragonfly-operator
that referenced
this pull request
Nov 18, 2023
* fix(e2e): add tests for latest features * use admin_nopass * also add --primary_port_http_enabled=false * use env for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.