Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monitoring): add guide for grafana dashboard #113

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Conversation

Abhra303
Copy link
Contributor

@Abhra303 Abhra303 commented Oct 6, 2023

No description provided.

@Abhra303 Abhra303 requested a review from Pothulapati October 11, 2023 09:01
Copy link
Collaborator

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 5 to 6
for further information on PodMonitor setup.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a line about the grafana-dashboard.json itself for folks who already have a grafana instance in their cluster here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@Abhra303 Abhra303 merged commit 210490c into main Oct 12, 2023
@Abhra303 Abhra303 deleted the ac/grafana-doc branch October 12, 2023 05:40
diffuse pushed a commit to diffuse/dragonfly-operator that referenced this pull request Nov 18, 2023
* add guide for grafana dashboard

* update dashboard json

* use pod name in  filter

* add filters in dashboard

* address review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants