fix long press with distance threshold

drag-drop-touch-js · Aug 8, 2024 · 5f618a7 · 5f618a7
1 parent 2166426
commit 5f618a7
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/demo/issue-77b/index.html b/demo/issue-77b/index.html
@@ -2,7 +2,7 @@
 <html>
   <head>
     <script type="module">
-      import { enableDragDropTouch } from "https://drag-drop-touch-js.github.io/dragdroptouch/dist/drag-drop-touch.esm.min.js";
+      import { enableDragDropTouch } from "/dist/drag-drop-touch.debug.esm.js";
 
       function enableBaseLine() {
         enableDragDropTouch();
@@ -17,7 +17,7 @@
       function enablePressHold5() {
         enableDragDropTouch(document, document, {
           isPressHoldMode: true,
-          pressHoldThresholdPixels: 5,
+          pressHoldThresholdPixels: 50,
         });
       }
 

diff --git a/dist/drag-drop-touch.esm.js b/dist/drag-drop-touch.esm.js
@@ -416,7 +416,7 @@ var DragDropTouch = class {
    * @returns
    */
   _getDelta(e) {
-    if (!this._ptDown || this.configuration.isPressHoldMode) return 0;
+    if (!this._ptDown) return 0;
     const { x, y } = this._ptDown;
     const p = pointFrom(e);
     return ((p.x - x) ** 2 + (p.y - y) ** 2) ** 0.5;

diff --git a/dist/drag-drop-touch.esm.min.js b/dist/drag-drop-touch.esm.min.js
diff --git a/ts/drag-drop-touch.ts b/ts/drag-drop-touch.ts
@@ -414,6 +414,11 @@ class DragDropTouch {
   _shouldStartDragging(e: TouchEvent) {
     let delta = this._getDelta(e);
     if (this.configuration.isPressHoldMode) {
+      DEBUG: console.log(
+        this.configuration.isPressHoldMode,
+        delta,
+        this.configuration.pressHoldThresholdPixels,
+      );
       return delta >= this.configuration.pressHoldThresholdPixels;
     }
     return delta > this.configuration.dragThresholdPixels;
@@ -440,9 +445,8 @@ class DragDropTouch {
    * @returns
    */
   _getDelta(e: TouchEvent) {
-    // if there is no active touch, or we're already in
-    // long press mode, we don't need to calculate anything.
-    if (!this._ptDown || this.configuration.isPressHoldMode) return 0;
+    // if there is no active touch we don't need to calculate anything.
+    if (!this._ptDown) return 0;
 
     // Determine how `far` from the event coordinate our
     // original touch coordinate was.